mirror of
https://github.com/bitwarden/server.git
synced 2025-05-22 20:11:04 -05:00

* PM-18939 refactoring send service to 'cqrs' * PM-18939 fixing import issue with sendValidationService * PM-18939 fixing code based on PR comments * PM-18339 reverting to previous code in test * PM-18939 adding XMLdocs to services * PM-18939 reverting send validation methods * PM-18939 updating code to match main * PM-18939 reverting validateUserCanSaveAsync to match main * PM-18939 fill our param and return sections of XMLdocs * PM-18939 updating XMLdocs based on PR comments * Update src/Core/Tools/SendFeatures/Commands/Interfaces/IAnonymousSendCommand.cs Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com> * Update src/Core/Tools/SendFeatures/Commands/Interfaces/INonAnonymousSendCommand.cs Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com> * Update src/Core/Tools/SendFeatures/Commands/Interfaces/INonAnonymousSendCommand.cs Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com> * Update src/Core/Tools/SendFeatures/Services/Interfaces/ISendStorageService.cs Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com> * PM-18939 adding commits to change tuple to enum type * PM-18939 resetting stream position to 0 when uploading file * PM-18939 updating XMLdocs based on PR comments * PM-18939 updating XMLdocs * PM-18939 removing circular dependency * PM-18939 fixing based on comments * PM-18939 updating method name and documentation --------- Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
117 lines
4.4 KiB
C#
117 lines
4.4 KiB
C#
using System.Text.Json;
|
|
using AutoFixture.Xunit2;
|
|
using Bit.Api.Tools.Controllers;
|
|
using Bit.Api.Tools.Models.Request;
|
|
using Bit.Api.Tools.Models.Response;
|
|
using Bit.Core.Context;
|
|
using Bit.Core.Entities;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Services;
|
|
using Bit.Core.Settings;
|
|
using Bit.Core.Tools.Entities;
|
|
using Bit.Core.Tools.Enums;
|
|
using Bit.Core.Tools.Models.Data;
|
|
using Bit.Core.Tools.Repositories;
|
|
using Bit.Core.Tools.SendFeatures.Commands.Interfaces;
|
|
using Bit.Core.Tools.Services;
|
|
using Bit.Core.Utilities;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.Extensions.Logging;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Api.Test.Tools.Controllers;
|
|
|
|
public class SendsControllerTests : IDisposable
|
|
{
|
|
private readonly SendsController _sut;
|
|
private readonly GlobalSettings _globalSettings;
|
|
private readonly IUserService _userService;
|
|
private readonly ISendRepository _sendRepository;
|
|
private readonly INonAnonymousSendCommand _nonAnonymousSendCommand;
|
|
private readonly IAnonymousSendCommand _anonymousSendCommand;
|
|
private readonly ISendAuthorizationService _sendAuthorizationService;
|
|
private readonly ISendFileStorageService _sendFileStorageService;
|
|
private readonly ILogger<SendsController> _logger;
|
|
private readonly ICurrentContext _currentContext;
|
|
|
|
public SendsControllerTests()
|
|
{
|
|
_userService = Substitute.For<IUserService>();
|
|
_sendRepository = Substitute.For<ISendRepository>();
|
|
_nonAnonymousSendCommand = Substitute.For<INonAnonymousSendCommand>();
|
|
_anonymousSendCommand = Substitute.For<IAnonymousSendCommand>();
|
|
_sendAuthorizationService = Substitute.For<ISendAuthorizationService>();
|
|
_sendFileStorageService = Substitute.For<ISendFileStorageService>();
|
|
_globalSettings = new GlobalSettings();
|
|
_logger = Substitute.For<ILogger<SendsController>>();
|
|
_currentContext = Substitute.For<ICurrentContext>();
|
|
|
|
_sut = new SendsController(
|
|
_sendRepository,
|
|
_userService,
|
|
_sendAuthorizationService,
|
|
_anonymousSendCommand,
|
|
_nonAnonymousSendCommand,
|
|
_sendFileStorageService,
|
|
_logger,
|
|
_globalSettings,
|
|
_currentContext
|
|
);
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
_sut?.Dispose();
|
|
}
|
|
|
|
[Theory, AutoData]
|
|
public async Task SendsController_WhenSendHidesEmail_CreatorIdentifierShouldBeNull(
|
|
Guid id, Send send, User user)
|
|
{
|
|
var accessId = CoreHelpers.Base64UrlEncode(id.ToByteArray());
|
|
|
|
send.Id = default;
|
|
send.Type = SendType.Text;
|
|
send.Data = JsonSerializer.Serialize(new Dictionary<string, string>());
|
|
send.HideEmail = true;
|
|
|
|
_sendRepository.GetByIdAsync(Arg.Any<Guid>()).Returns(send);
|
|
_sendAuthorizationService.AccessAsync(send, null).Returns(SendAccessResult.Granted);
|
|
_userService.GetUserByIdAsync(Arg.Any<Guid>()).Returns(user);
|
|
|
|
var request = new SendAccessRequestModel();
|
|
var actionResult = await _sut.Access(accessId, request);
|
|
var response = (actionResult as ObjectResult)?.Value as SendAccessResponseModel;
|
|
|
|
Assert.NotNull(response);
|
|
Assert.Null(response.CreatorIdentifier);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Post_DeletionDateIsMoreThan31DaysFromNow_ThrowsBadRequest()
|
|
{
|
|
var now = DateTime.UtcNow;
|
|
var expected = "You cannot have a Send with a deletion date that far " +
|
|
"into the future. Adjust the Deletion Date to a value less than 31 days from now " +
|
|
"and try again.";
|
|
var request = new SendRequestModel() { DeletionDate = now.AddDays(32) };
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => _sut.Post(request));
|
|
Assert.Equal(expected, exception.Message);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task PostFile_DeletionDateIsMoreThan31DaysFromNow_ThrowsBadRequest()
|
|
{
|
|
var now = DateTime.UtcNow;
|
|
var expected = "You cannot have a Send with a deletion date that far " +
|
|
"into the future. Adjust the Deletion Date to a value less than 31 days from now " +
|
|
"and try again.";
|
|
var request = new SendRequestModel() { Type = SendType.File, FileLength = 1024L, DeletionDate = now.AddDays(32) };
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => _sut.PostFile(request));
|
|
Assert.Equal(expected, exception.Message);
|
|
}
|
|
}
|