mirror of
https://github.com/bitwarden/server.git
synced 2025-06-07 03:30:32 -05:00

* [EC-19] Move SSO Identifier to Org SSO endpoint (#2184) * [EC-19] Move SSO identifier to Org SSO config endpoint * [EC-19] Add Jira tech debt issue reference * [EC-542] Update email communications (#2348) * [EC-73] Add users alongside groups for collection details (#2358) * [EC-73] feat: add new stored procedures * [EC-73] feat: add migration * [EC-73] chore: rename collection group details * [EC-73] fix: migration * [EC-73] feat: return users from dapper repo * [EC-73] feat: EF support for collection users * [EC-73] feat: implement updating users in EF * [EC-73] feat: new collections with users in EF * [EC-73] feat: create with users in dapper * [EC-73] feat: update with users in dapper * [EC-73] fix: collection service tests * [EC-73] fix: lint * [EC-73] feat: add new data model and rename for clarity * [EC-73] chore: add future migrations * [EC-16 / EC-86] Implement Groups Table Endpoints (#2280) * [EC-16] Update Group endpoints/repositories to include necessary collection info * [EC-16] Add delete many groups endpoint and command * [EC-16] Add DeleteGroupCommand unit tests * [EC-16] Update migration script * [EC-16] Formatting * [EC-16] Support modifying users via Post Group endpoint - Add optional Users property to GroupRequestModel - Add users parameter to the GroupService.SaveAsync() method - Use the users argument to update the Group via the GroupRepository if present. * [EC-16] Add/update Sprocs for bulk group deletion - Add a new bump account revision date by multiple org ids sproc to be used by the delete many group sproc. - Update the delete many group sproc to no longer require the organization Id as authorization is a business concern. * [EC-16] No longer require org Id in delete many GroupRepository The group repository should not care about which organization a group belongs to when being deleted. That is a business logic concern and is not necessary at the repository level. * [EC-16] Remove org Id from delete many group command - Remove the organization Id from the delete many method. - Require Group entities instead of just group Ids so that group retrieval is completed outside the command. - No longer return deleted groups as they are now being passed into the command. - Update unit tests * [EC-16] Remove org id from bulk delete group endpoint - Remove the Org Id from the endpoint and make use of the updated delete many command * [EC-16] Rename delete many groups sproc * [EC-16] Update migration script * [EC-16] Fix typo in migration script * [EC-16] Fix order of operations in Group_DeleteByIds sproc * [EC-16] Formatting * [EC-86] Fix DeleteManyAsync parameter name Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> * [EC-16] Add missing sproc to sqlproj file * [EC-16] Improve GroupRepository method performance Use GroupBy before marrying Groups and Collections to avoid iterating over all collections for every group) * [EC-16] Use ToListAsync() to be consistent in the repository * [EC-16] Fix collection grouping in the EF repository * [EC-16] Adjust DeleteGroup command namespace to be less verbose * [EC-16] Cleanup DeleteGroupCommandTests * [EC-16] Formatting * [EC-16] Ensure a non-null group collection list is provided * [EC-16] Add bulk GroupEvents method to EventService - Use the new method in the DeleteGroups command * [EC-16] Remove bulk delete group Api response The response is unnecessary and not used by the client * [EC-16] Log OrganizationUser_UpdateGroups event in GroupService Events are logged for users during both Group creation (all added users) and modification (only changed users). * [EC-16] Fix failing unit test * [EC-16] Rename newUsers variable per feedback * [EC-16] Assert delete many group log events Explicitly check for the event type and groups that are logged to the event service. * [EC-16] Update DeleteManyAsync signature Use ICollection<> instead of IEnumerable<> to avoid ambiguity of possible multiple enumeration * [EC-16] Increment migration script name Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> * Add missing GO command to EC-73 migration script (#2433) * [EC-15] Members Grid Api Support (#2485) * [EC-15] Update OrganizationUser models to support list of collections and groups * [EC-15] Add sprocs to query GroupUser and CollectionUser entities * [EC-15] Update the OrganizationUserRepository to optionally fetch groups/collections * [EC-15] Formatting * [EC-15] Remove leftover repository method * [EC-15] Fix table identifier inconsistency in sproc/migration * Formatting * [EC-14]: Server changes for Collection rows in Vault (#2360) * [EC-14] add collection management methods to repo - delete many, get many by ids, and get many with groups by org * [EC-14] connection command tests had wrong folder name * [EC-14] add collection repo methods to interface * [EC-14] create DeleteCollectionCommand * [EC-14] add getManyWithDetails collections endpoint * [EC-14] add GetManyWithGroupsByUserId * [EC-14] add call to interface * [EC-14] add GetOrganizationCollectionsWIthGroups - gets groups with collections - add tests as well * [EC-14] add call to interface * [EC-14] add new coll call to controller - gets collections with groups * [EC-14] use new delete collection command * [EC-14] add CollectionBulkDeleteRequestModel * [EC-14] remove org from delete collection cmd - move all permission checks to controller - add tests to controller - remove org check from repository method * [EC-14] add migration and sprocs * [EC-14] formatting * [EC-14] revert delete permission check changes * [EC-14] rename SelectionReadOnly to CollectionAccessSelection * [EC-14] move GetOrganizationCollectionsWithGroups to controller - there's no reason to have this logic in the service layer - we can still test the permission check in the controller - also renamed repo methods and changed return types * [EC-14] include users in collection access details * [EC-14] fix migration names * [EC-14] bumpAccountRevisionDate when deleting collections * [EC-14] new line in collection service * [EC-14] formatting and add .sql to proc file * [EC-14] more formatting * [EC-14] formatting * [EC-14] fix whitespace * [EC-14] add datetime to event log of single delete * [EC-14] remove ToList() from enumerables not returned * [EC-14] fix permissions on "Create new collection" - a custom user with "Create new collections" should see all collections * [EC-14] add bulk events for collections * [EC-14] group collections from db before iterating * [EC-14] sql formatting and missing GO * [EC-14] fix tests * [EC-14] add null handling to repo methods * [EC-14] fix account revision call * [EC-14] formatting * [EC-548] Member Details Group Tab (#2508) * [EC-548] Update models to support groups * [EC-548] Include groups in invite and save organization user methods * [EC-548] Pass groups to service methods in member/user controllers * [EC-548] Fix failing tests * [EC-548] Add option to include groups for GET org user query * Formatting * [EC-887] Server fix for managers seeing options to edit/delete Collections they aren't assigned to (#2542) * [EC-887] Add Assigned property to CollectionResponseModel A new property to determine if a collection is assigned to the acting user; as some users, have the view all collections permission, but cannot see every collection's items * [EC-887] Update logic for retrieving GET all collection details - Only need to check the ViewAllCollections permission - Calculate new Assigned response property based on the assignedOrgCollections list * Formatting * [EC-887] Update unit tests Co-authored-by: Shane Melton <smelton@bitwarden.com> Co-authored-by: Jacob Fink <jfink@bitwarden.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
270 lines
11 KiB
C#
270 lines
11 KiB
C#
using AutoMapper;
|
|
using Bit.Core.Models.Data;
|
|
using Bit.Core.Repositories;
|
|
using Bit.Infrastructure.EntityFramework.Models;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
|
|
namespace Bit.Infrastructure.EntityFramework.Repositories;
|
|
|
|
public class GroupRepository : Repository<Core.Entities.Group, Group, Guid>, IGroupRepository
|
|
{
|
|
public GroupRepository(IServiceScopeFactory serviceScopeFactory, IMapper mapper)
|
|
: base(serviceScopeFactory, mapper, (DatabaseContext context) => context.Groups)
|
|
{ }
|
|
|
|
public async Task CreateAsync(Core.Entities.Group obj, IEnumerable<CollectionAccessSelection> collections)
|
|
{
|
|
var grp = await base.CreateAsync(obj);
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var availibleCollections = await (
|
|
from c in dbContext.Collections
|
|
where c.OrganizationId == grp.OrganizationId
|
|
select c).ToListAsync();
|
|
var filteredCollections = collections.Where(c => availibleCollections.Any(a => c.Id == a.Id));
|
|
var collectionGroups = filteredCollections.Select(y => new CollectionGroup
|
|
{
|
|
CollectionId = y.Id,
|
|
GroupId = grp.Id,
|
|
ReadOnly = y.ReadOnly,
|
|
HidePasswords = y.HidePasswords,
|
|
});
|
|
await dbContext.CollectionGroups.AddRangeAsync(collectionGroups);
|
|
await dbContext.SaveChangesAsync();
|
|
}
|
|
}
|
|
|
|
public async Task DeleteUserAsync(Guid groupId, Guid organizationUserId)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var query = from gu in dbContext.GroupUsers
|
|
where gu.GroupId == groupId &&
|
|
gu.OrganizationUserId == organizationUserId
|
|
select gu;
|
|
dbContext.RemoveRange(await query.ToListAsync());
|
|
await dbContext.UserBumpAccountRevisionDateByOrganizationUserIdAsync(organizationUserId);
|
|
await dbContext.SaveChangesAsync();
|
|
}
|
|
}
|
|
|
|
public async Task<Tuple<Core.Entities.Group, ICollection<CollectionAccessSelection>>> GetByIdWithCollectionsAsync(Guid id)
|
|
{
|
|
var grp = await base.GetByIdAsync(id);
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var query = await (
|
|
from cg in dbContext.CollectionGroups
|
|
where cg.GroupId == id
|
|
select cg).ToListAsync();
|
|
var collections = query.Select(c => new CollectionAccessSelection
|
|
{
|
|
Id = c.CollectionId,
|
|
ReadOnly = c.ReadOnly,
|
|
HidePasswords = c.HidePasswords,
|
|
}).ToList();
|
|
return new Tuple<Core.Entities.Group, ICollection<CollectionAccessSelection>>(
|
|
grp, collections);
|
|
}
|
|
}
|
|
|
|
public async Task<ICollection<Core.Entities.Group>> GetManyByOrganizationIdAsync(Guid organizationId)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var data = await (
|
|
from g in dbContext.Groups
|
|
where g.OrganizationId == organizationId
|
|
select g).ToListAsync();
|
|
return Mapper.Map<List<Core.Entities.Group>>(data);
|
|
}
|
|
}
|
|
|
|
public async Task<ICollection<Tuple<Core.Entities.Group, ICollection<CollectionAccessSelection>>>>
|
|
GetManyWithCollectionsByOrganizationIdAsync(Guid organizationId)
|
|
{
|
|
var groups = await GetManyByOrganizationIdAsync(organizationId);
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var query = await (
|
|
from cg in dbContext.CollectionGroups
|
|
where cg.Group.OrganizationId == organizationId
|
|
select cg).ToListAsync();
|
|
|
|
var collections = query.GroupBy(c => c.GroupId).ToList();
|
|
|
|
return groups.Select(group =>
|
|
new Tuple<Core.Entities.Group, ICollection<CollectionAccessSelection>>(
|
|
group,
|
|
collections
|
|
.FirstOrDefault(c => c.Key == group.Id)?
|
|
.Select(c => new CollectionAccessSelection
|
|
{
|
|
Id = c.CollectionId,
|
|
HidePasswords = c.HidePasswords,
|
|
ReadOnly = c.ReadOnly
|
|
}
|
|
).ToList() ?? new List<CollectionAccessSelection>())
|
|
).ToList();
|
|
}
|
|
}
|
|
|
|
public async Task<ICollection<Core.Entities.Group>> GetManyByManyIds(IEnumerable<Guid> groupIds)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var query = from g in dbContext.Groups
|
|
where groupIds.Contains(g.Id)
|
|
select g;
|
|
var groups = await query.ToListAsync();
|
|
return Mapper.Map<List<Core.Entities.Group>>(groups);
|
|
}
|
|
}
|
|
|
|
public async Task<ICollection<Core.Entities.GroupUser>> GetManyGroupUsersByOrganizationIdAsync(Guid organizationId)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var query =
|
|
from gu in dbContext.GroupUsers
|
|
join g in dbContext.Groups
|
|
on gu.GroupId equals g.Id
|
|
where g.OrganizationId == organizationId
|
|
select gu;
|
|
var groupUsers = await query.ToListAsync();
|
|
return Mapper.Map<List<Core.Entities.GroupUser>>(groupUsers);
|
|
}
|
|
}
|
|
|
|
public async Task<ICollection<Guid>> GetManyIdsByUserIdAsync(Guid organizationUserId)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var query =
|
|
from gu in dbContext.GroupUsers
|
|
where gu.OrganizationUserId == organizationUserId
|
|
select gu;
|
|
var groupIds = await query.Select(x => x.GroupId).ToListAsync();
|
|
return groupIds;
|
|
}
|
|
}
|
|
|
|
public async Task<ICollection<Guid>> GetManyUserIdsByIdAsync(Guid id)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var query =
|
|
from gu in dbContext.GroupUsers
|
|
where gu.GroupId == id
|
|
select gu;
|
|
var groupIds = await query.Select(x => x.OrganizationUserId).ToListAsync();
|
|
return groupIds;
|
|
}
|
|
}
|
|
|
|
public async Task ReplaceAsync(Core.Entities.Group group, IEnumerable<CollectionAccessSelection> requestedCollections)
|
|
{
|
|
await base.ReplaceAsync(group);
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
|
|
var availableCollections = await dbContext.Collections
|
|
.Where(c => c.OrganizationId == group.OrganizationId)
|
|
.Select(c => c.Id)
|
|
.ToListAsync();
|
|
|
|
var existingCollectionGroups = await dbContext.CollectionGroups
|
|
.Where(cg => cg.GroupId == group.Id)
|
|
.ToListAsync();
|
|
|
|
foreach (var requestedCollection in requestedCollections)
|
|
{
|
|
var existingCollectionGroup = existingCollectionGroups
|
|
.FirstOrDefault(cg => cg.CollectionId == requestedCollection.Id);
|
|
|
|
if (existingCollectionGroup == null)
|
|
{
|
|
// It needs to be added
|
|
dbContext.CollectionGroups.Add(new CollectionGroup
|
|
{
|
|
CollectionId = requestedCollection.Id,
|
|
GroupId = group.Id,
|
|
ReadOnly = requestedCollection.ReadOnly,
|
|
HidePasswords = requestedCollection.HidePasswords,
|
|
});
|
|
continue;
|
|
}
|
|
|
|
existingCollectionGroup.ReadOnly = requestedCollection.ReadOnly;
|
|
existingCollectionGroup.HidePasswords = requestedCollection.HidePasswords;
|
|
}
|
|
|
|
var requestedCollectionIds = requestedCollections.Select(c => c.Id);
|
|
|
|
dbContext.CollectionGroups.RemoveRange(
|
|
existingCollectionGroups.Where(cg => !requestedCollectionIds.Contains(cg.CollectionId)));
|
|
|
|
await dbContext.UserBumpAccountRevisionDateByOrganizationIdAsync(group.OrganizationId);
|
|
await dbContext.SaveChangesAsync();
|
|
}
|
|
}
|
|
|
|
public async Task UpdateUsersAsync(Guid groupId, IEnumerable<Guid> organizationUserIds)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var orgId = (await dbContext.Groups.FindAsync(groupId)).OrganizationId;
|
|
var insert = from ou in dbContext.OrganizationUsers
|
|
where organizationUserIds.Contains(ou.Id) &&
|
|
ou.OrganizationId == orgId &&
|
|
!dbContext.GroupUsers.Any(gu => gu.GroupId == groupId && ou.Id == gu.OrganizationUserId)
|
|
select new GroupUser
|
|
{
|
|
GroupId = groupId,
|
|
OrganizationUserId = ou.Id,
|
|
};
|
|
await dbContext.AddRangeAsync(insert);
|
|
|
|
var delete = from gu in dbContext.GroupUsers
|
|
where gu.GroupId == groupId &&
|
|
!organizationUserIds.Contains(gu.OrganizationUserId)
|
|
select gu;
|
|
dbContext.RemoveRange(delete);
|
|
await dbContext.SaveChangesAsync();
|
|
await dbContext.UserBumpAccountRevisionDateByOrganizationIdAsync(orgId);
|
|
await dbContext.SaveChangesAsync();
|
|
}
|
|
}
|
|
|
|
public async Task DeleteManyAsync(IEnumerable<Guid> groupIds)
|
|
{
|
|
using (var scope = ServiceScopeFactory.CreateScope())
|
|
{
|
|
var dbContext = GetDatabaseContext(scope);
|
|
var entities = await dbContext.Groups
|
|
.Where(g => groupIds.Contains(g.Id))
|
|
.ToListAsync();
|
|
|
|
dbContext.Groups.RemoveRange(entities);
|
|
await dbContext.SaveChangesAsync();
|
|
|
|
foreach (var group in entities.GroupBy(g => g.Organization.Id))
|
|
{
|
|
await dbContext.UserBumpAccountRevisionDateByOrganizationIdAsync(group.Key);
|
|
}
|
|
}
|
|
}
|
|
}
|