mirror of
https://github.com/bitwarden/server.git
synced 2025-04-24 06:25:09 -05:00
90d831d9ef
* [PM-17562] Slack Event Investigation * Refactored Slack and Webhook integrations to pull configurations dynamically from a new Repository * Added new TemplateProcessor and added/updated unit tests * SlackService improvements, testing, integration configurations * Refactor SlackService to use a dedicated model to parse responses * Refactored SlackOAuthController to use SlackService as an injected dependency; added tests for SlackService * Remove unnecessary methods from the IOrganizationIntegrationConfigurationRepository * Moved Slack OAuth to take into account the Organization it's being stored for. Added methods to store the top level integration for Slack * Organization integrations and configuration database schemas * Format EF files * Initial buildout of basic repositories * [PM-17562] Add Dapper Repositories For Organization Integrations and Configurations * Update Slack and Webhook handlers to use new Repositories * Update SlackOAuth tests to new signatures * Added EF Repositories * Update handlers to use latest repositories * [PM-17562] Add Dapper and EF Repositories For Ogranization Integrations and Configurations * Updated with changes from PR comments * Adjusted Handlers to new repository method names; updated tests to naming convention * Adjust URL structure; add delete for Slack, add tests * Added Webhook Integration Controller * Add tests for WebhookIntegrationController * Added Create/Delete for OrganizationIntegrationConfigurations * Prepend ConnectionTypes into IntegrationType so we don't run into issues later * Added Update to OrganizationIntegrationConfigurtionController * Moved Webhook-specific integration code to being a generic controller for everything but Slack * Removed delete from SlackController - Deletes should happen through the normal Integration controller * Fixed SlackController, reworked OIC Controller to use ids from URL and update the returned object * Added parse/type checking for integration and integration configuration JSONs, Cleaned up GlobalSettings to remove old values * Cleanup and fixes for Azure Service Bus support * Clean up naming on TemplateProcessorTests * Address SonarQube warnings/suggestions * Expanded test coverage; Cleaned up tests * Respond to PR Feedback * Rename TemplateProcessor to IntegrationTemplateProcessor --------- Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
622 lines
30 KiB
C#
622 lines
30 KiB
C#
using System.Text.Json;
|
|
using Bit.Api.AdminConsole.Controllers;
|
|
using Bit.Api.AdminConsole.Models.Request.Organizations;
|
|
using Bit.Api.AdminConsole.Models.Response.Organizations;
|
|
using Bit.Core.AdminConsole.Entities;
|
|
using Bit.Core.Context;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Models.Data.Integrations;
|
|
using Bit.Core.Repositories;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using NSubstitute;
|
|
using NSubstitute.ReturnsExtensions;
|
|
using Xunit;
|
|
|
|
namespace Bit.Api.Test.AdminConsole.Controllers;
|
|
|
|
[ControllerCustomize(typeof(OrganizationIntegrationConfigurationController))]
|
|
[SutProviderCustomize]
|
|
public class OrganizationIntegrationsConfigurationControllerTests
|
|
{
|
|
[Theory, BitAutoData]
|
|
public async Task DeleteAsync_AllParamsProvided_Succeeds(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegrationConfiguration.OrganizationIntegrationId = organizationIntegration.Id;
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await sutProvider.Sut.DeleteAsync(organizationId, organizationIntegration.Id, organizationIntegrationConfiguration.Id);
|
|
|
|
await sutProvider.GetDependency<IOrganizationIntegrationRepository>().Received(1)
|
|
.GetByIdAsync(organizationIntegration.Id);
|
|
await sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>().Received(1)
|
|
.GetByIdAsync(organizationIntegrationConfiguration.Id);
|
|
await sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>().Received(1)
|
|
.DeleteAsync(organizationIntegrationConfiguration);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task DeleteAsync_IntegrationConfigurationDoesNotExist_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.ReturnsNull();
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.DeleteAsync(organizationId, Guid.Empty, Guid.Empty));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task DeleteAsync_IntegrationDoesNotExist_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.ReturnsNull();
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.DeleteAsync(organizationId, Guid.Empty, Guid.Empty));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task DeleteAsync_IntegrationDoesNotBelongToOrganization_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.DeleteAsync(organizationId, organizationIntegration.Id, Guid.Empty));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task DeleteAsync_IntegrationConfigDoesNotBelongToIntegration_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegrationConfiguration.OrganizationIntegrationId = Guid.Empty;
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.DeleteAsync(organizationId, organizationIntegration.Id, Guid.Empty));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task DeleteAsync_UserIsNotOrganizationAdmin_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(false);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.DeleteAsync(organizationId, Guid.Empty, Guid.Empty));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_AllParamsProvided_Slack_Succeeds(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegration.Type = IntegrationType.Slack;
|
|
var slackConfig = new SlackIntegrationConfiguration(channelId: "C123456");
|
|
model.Configuration = JsonSerializer.Serialize(slackConfig);
|
|
model.Template = "Template String";
|
|
|
|
var expected = new OrganizationIntegrationConfigurationResponseModel(organizationIntegrationConfiguration);
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
var requestAction = await sutProvider.Sut.CreateAsync(organizationId, organizationIntegration.Id, model);
|
|
|
|
await sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>().Received(1)
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>());
|
|
Assert.IsType<OrganizationIntegrationConfigurationResponseModel>(requestAction);
|
|
Assert.Equal(expected.Id, requestAction.Id);
|
|
Assert.Equal(expected.Configuration, requestAction.Configuration);
|
|
Assert.Equal(expected.EventType, requestAction.EventType);
|
|
Assert.Equal(expected.Template, requestAction.Template);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_AllParamsProvided_Webhook_Succeeds(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegration.Type = IntegrationType.Webhook;
|
|
var webhookConfig = new WebhookIntegrationConfiguration(url: "https://localhost");
|
|
model.Configuration = JsonSerializer.Serialize(webhookConfig);
|
|
model.Template = "Template String";
|
|
|
|
var expected = new OrganizationIntegrationConfigurationResponseModel(organizationIntegrationConfiguration);
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
var requestAction = await sutProvider.Sut.CreateAsync(organizationId, organizationIntegration.Id, model);
|
|
|
|
await sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>().Received(1)
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>());
|
|
Assert.IsType<OrganizationIntegrationConfigurationResponseModel>(requestAction);
|
|
Assert.Equal(expected.Id, requestAction.Id);
|
|
Assert.Equal(expected.Configuration, requestAction.Configuration);
|
|
Assert.Equal(expected.EventType, requestAction.EventType);
|
|
Assert.Equal(expected.Template, requestAction.Template);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_IntegrationTypeCloudBillingSync_ThrowsBadRequestException(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegration.Type = IntegrationType.CloudBillingSync;
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.CreateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
model));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_IntegrationTypeScim_ThrowsBadRequestException(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegration.Type = IntegrationType.Scim;
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.CreateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
model));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_IntegrationDoesNotExist_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.ReturnsNull();
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.CreateAsync(
|
|
organizationId,
|
|
Guid.Empty,
|
|
new OrganizationIntegrationConfigurationRequestModel()));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_IntegrationDoesNotBelongToOrganization_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.CreateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
new OrganizationIntegrationConfigurationRequestModel()));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_InvalidConfiguration_ThrowsBadRequestException(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegration.Type = IntegrationType.Webhook;
|
|
model.Configuration = null;
|
|
model.Template = "Template String";
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.CreateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
model));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_InvalidTemplate_ThrowsBadRequestException(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegration.Type = IntegrationType.Webhook;
|
|
var webhookConfig = new WebhookIntegrationConfiguration(url: "https://localhost");
|
|
model.Configuration = JsonSerializer.Serialize(webhookConfig);
|
|
model.Template = null;
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.CreateAsync(Arg.Any<OrganizationIntegrationConfiguration>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.CreateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
model));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task PostAsync_UserIsNotOrganizationAdmin_ThrowsNotFound(SutProvider<OrganizationIntegrationConfigurationController> sutProvider, Guid organizationId)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(false);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.CreateAsync(organizationId, Guid.Empty, new OrganizationIntegrationConfigurationRequestModel()));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_AllParamsProvided_Slack_Succeeds(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegrationConfiguration.OrganizationIntegrationId = organizationIntegration.Id;
|
|
organizationIntegration.Type = IntegrationType.Slack;
|
|
var slackConfig = new SlackIntegrationConfiguration(channelId: "C123456");
|
|
model.Configuration = JsonSerializer.Serialize(slackConfig);
|
|
model.Template = "Template String";
|
|
|
|
var expected = new OrganizationIntegrationConfigurationResponseModel(model.ToOrganizationIntegrationConfiguration(organizationIntegrationConfiguration));
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
var requestAction = await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
organizationIntegrationConfiguration.Id,
|
|
model);
|
|
|
|
await sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>().Received(1)
|
|
.ReplaceAsync(Arg.Any<OrganizationIntegrationConfiguration>());
|
|
Assert.IsType<OrganizationIntegrationConfigurationResponseModel>(requestAction);
|
|
Assert.Equal(expected.Id, requestAction.Id);
|
|
Assert.Equal(expected.Configuration, requestAction.Configuration);
|
|
Assert.Equal(expected.EventType, requestAction.EventType);
|
|
Assert.Equal(expected.Template, requestAction.Template);
|
|
}
|
|
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_AllParamsProvided_Webhook_Succeeds(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegrationConfiguration.OrganizationIntegrationId = organizationIntegration.Id;
|
|
organizationIntegration.Type = IntegrationType.Webhook;
|
|
var webhookConfig = new WebhookIntegrationConfiguration(url: "https://localhost");
|
|
model.Configuration = JsonSerializer.Serialize(webhookConfig);
|
|
model.Template = "Template String";
|
|
|
|
var expected = new OrganizationIntegrationConfigurationResponseModel(model.ToOrganizationIntegrationConfiguration(organizationIntegrationConfiguration));
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
var requestAction = await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
organizationIntegrationConfiguration.Id,
|
|
model);
|
|
|
|
await sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>().Received(1)
|
|
.ReplaceAsync(Arg.Any<OrganizationIntegrationConfiguration>());
|
|
Assert.IsType<OrganizationIntegrationConfigurationResponseModel>(requestAction);
|
|
Assert.Equal(expected.Id, requestAction.Id);
|
|
Assert.Equal(expected.Configuration, requestAction.Configuration);
|
|
Assert.Equal(expected.EventType, requestAction.EventType);
|
|
Assert.Equal(expected.Template, requestAction.Template);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_IntegrationConfigurationDoesNotExist_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegration.Type = IntegrationType.Webhook;
|
|
var webhookConfig = new WebhookIntegrationConfiguration(url: "https://localhost");
|
|
model.Configuration = JsonSerializer.Serialize(webhookConfig);
|
|
model.Template = "Template String";
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.ReturnsNull();
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
Guid.Empty,
|
|
model));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_IntegrationDoesNotExist_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.ReturnsNull();
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
Guid.Empty,
|
|
Guid.Empty,
|
|
new OrganizationIntegrationConfigurationRequestModel()));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_IntegrationDoesNotBelongToOrganization_ThrowsNotFound(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
Guid.Empty,
|
|
new OrganizationIntegrationConfigurationRequestModel()));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_InvalidConfiguration_ThrowsBadRequestException(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegrationConfiguration.OrganizationIntegrationId = organizationIntegration.Id;
|
|
organizationIntegration.Type = IntegrationType.Slack;
|
|
model.Configuration = null;
|
|
model.Template = "Template String";
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
organizationIntegrationConfiguration.Id,
|
|
model));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_InvalidTemplate_ThrowsBadRequestException(
|
|
SutProvider<OrganizationIntegrationConfigurationController> sutProvider,
|
|
Guid organizationId,
|
|
OrganizationIntegration organizationIntegration,
|
|
OrganizationIntegrationConfiguration organizationIntegrationConfiguration,
|
|
OrganizationIntegrationConfigurationRequestModel model)
|
|
{
|
|
organizationIntegration.OrganizationId = organizationId;
|
|
organizationIntegrationConfiguration.OrganizationIntegrationId = organizationIntegration.Id;
|
|
organizationIntegration.Type = IntegrationType.Slack;
|
|
var slackConfig = new SlackIntegrationConfiguration(channelId: "C123456");
|
|
model.Configuration = JsonSerializer.Serialize(slackConfig);
|
|
model.Template = null;
|
|
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(true);
|
|
sutProvider.GetDependency<IOrganizationIntegrationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegration);
|
|
sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>()
|
|
.GetByIdAsync(Arg.Any<Guid>())
|
|
.Returns(organizationIntegrationConfiguration);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
organizationIntegration.Id,
|
|
organizationIntegrationConfiguration.Id,
|
|
model));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task UpdateAsync_UserIsNotOrganizationAdmin_ThrowsNotFound(SutProvider<OrganizationIntegrationConfigurationController> sutProvider, Guid organizationId)
|
|
{
|
|
sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.OrganizationOwner(organizationId)
|
|
.Returns(false);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.UpdateAsync(
|
|
organizationId,
|
|
Guid.Empty,
|
|
Guid.Empty,
|
|
new OrganizationIntegrationConfigurationRequestModel()));
|
|
}
|
|
}
|