mirror of
https://github.com/bitwarden/server.git
synced 2025-04-24 14:26:38 -05:00

* [PM-19180] Calculate sales tax correctly for sponsored plans * Cannot divide by zero if total amount excluding tax is zero. * Unit tests for families & families for enterprise --------- Co-authored-by: Conner Turnbull <133619638+cturnbull-bitwarden@users.noreply.github.com>
228 lines
8.6 KiB
C#
228 lines
8.6 KiB
C#
using Bit.Core.Billing.Enums;
|
|
using Bit.Core.Billing.Models.Api.Requests;
|
|
using Bit.Core.Billing.Models.Api.Requests.Organizations;
|
|
using Bit.Core.Billing.Models.StaticStore.Plans;
|
|
using Bit.Core.Billing.Pricing;
|
|
using Bit.Core.Billing.Services;
|
|
using Bit.Core.Billing.Services.Contracts;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Services;
|
|
using Bit.Core.Test.Billing.Stubs;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using NSubstitute;
|
|
using Stripe;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.Services;
|
|
|
|
[SutProviderCustomize]
|
|
public class StripePaymentServiceTests
|
|
{
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PreviewInvoiceAsync_ForOrganization_CalculatesSalesTaxCorrectlyForFamiliesWithoutAdditionalStorage(
|
|
SutProvider<StripePaymentService> sutProvider)
|
|
{
|
|
sutProvider.GetDependency<IAutomaticTaxFactory>()
|
|
.CreateAsync(Arg.Is<AutomaticTaxFactoryParameters>(p => p.PlanType == PlanType.FamiliesAnnually))
|
|
.Returns(new FakeAutomaticTaxStrategy(true));
|
|
|
|
var familiesPlan = new FamiliesPlan();
|
|
sutProvider.GetDependency<IPricingClient>()
|
|
.GetPlanOrThrow(Arg.Is<PlanType>(p => p == PlanType.FamiliesAnnually))
|
|
.Returns(familiesPlan);
|
|
|
|
var parameters = new PreviewOrganizationInvoiceRequestBody
|
|
{
|
|
PasswordManager = new OrganizationPasswordManagerRequestModel
|
|
{
|
|
Plan = PlanType.FamiliesAnnually,
|
|
AdditionalStorage = 0
|
|
},
|
|
TaxInformation = new TaxInformationRequestModel
|
|
{
|
|
Country = "FR",
|
|
PostalCode = "12345"
|
|
}
|
|
};
|
|
|
|
sutProvider.GetDependency<IStripeAdapter>()
|
|
.InvoiceCreatePreviewAsync(Arg.Is<InvoiceCreatePreviewOptions>(p =>
|
|
p.Currency == "usd" &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == familiesPlan.PasswordManager.StripePlanId &&
|
|
x.Quantity == 1) &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == familiesPlan.PasswordManager.StripeStoragePlanId &&
|
|
x.Quantity == 0)))
|
|
.Returns(new Invoice
|
|
{
|
|
TotalExcludingTax = 4000,
|
|
Tax = 800,
|
|
Total = 4800
|
|
});
|
|
|
|
var actual = await sutProvider.Sut.PreviewInvoiceAsync(parameters, null, null);
|
|
|
|
Assert.Equal(8M, actual.TaxAmount);
|
|
Assert.Equal(48M, actual.TotalAmount);
|
|
Assert.Equal(40M, actual.TaxableBaseAmount);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PreviewInvoiceAsync_ForOrganization_CalculatesSalesTaxCorrectlyForFamiliesWithAdditionalStorage(
|
|
SutProvider<StripePaymentService> sutProvider)
|
|
{
|
|
sutProvider.GetDependency<IAutomaticTaxFactory>()
|
|
.CreateAsync(Arg.Is<AutomaticTaxFactoryParameters>(p => p.PlanType == PlanType.FamiliesAnnually))
|
|
.Returns(new FakeAutomaticTaxStrategy(true));
|
|
|
|
var familiesPlan = new FamiliesPlan();
|
|
sutProvider.GetDependency<IPricingClient>()
|
|
.GetPlanOrThrow(Arg.Is<PlanType>(p => p == PlanType.FamiliesAnnually))
|
|
.Returns(familiesPlan);
|
|
|
|
var parameters = new PreviewOrganizationInvoiceRequestBody
|
|
{
|
|
PasswordManager = new OrganizationPasswordManagerRequestModel
|
|
{
|
|
Plan = PlanType.FamiliesAnnually,
|
|
AdditionalStorage = 1
|
|
},
|
|
TaxInformation = new TaxInformationRequestModel
|
|
{
|
|
Country = "FR",
|
|
PostalCode = "12345"
|
|
}
|
|
};
|
|
|
|
sutProvider.GetDependency<IStripeAdapter>()
|
|
.InvoiceCreatePreviewAsync(Arg.Is<InvoiceCreatePreviewOptions>(p =>
|
|
p.Currency == "usd" &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == familiesPlan.PasswordManager.StripePlanId &&
|
|
x.Quantity == 1) &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == familiesPlan.PasswordManager.StripeStoragePlanId &&
|
|
x.Quantity == 1)))
|
|
.Returns(new Invoice
|
|
{
|
|
TotalExcludingTax = 4000,
|
|
Tax = 800,
|
|
Total = 4800
|
|
});
|
|
|
|
var actual = await sutProvider.Sut.PreviewInvoiceAsync(parameters, null, null);
|
|
|
|
Assert.Equal(8M, actual.TaxAmount);
|
|
Assert.Equal(48M, actual.TotalAmount);
|
|
Assert.Equal(40M, actual.TaxableBaseAmount);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PreviewInvoiceAsync_ForOrganization_CalculatesSalesTaxCorrectlyForFamiliesForEnterpriseWithoutAdditionalStorage(
|
|
SutProvider<StripePaymentService> sutProvider)
|
|
{
|
|
sutProvider.GetDependency<IAutomaticTaxFactory>()
|
|
.CreateAsync(Arg.Is<AutomaticTaxFactoryParameters>(p => p.PlanType == PlanType.FamiliesAnnually))
|
|
.Returns(new FakeAutomaticTaxStrategy(true));
|
|
|
|
var familiesPlan = new FamiliesPlan();
|
|
sutProvider.GetDependency<IPricingClient>()
|
|
.GetPlanOrThrow(Arg.Is<PlanType>(p => p == PlanType.FamiliesAnnually))
|
|
.Returns(familiesPlan);
|
|
|
|
var parameters = new PreviewOrganizationInvoiceRequestBody
|
|
{
|
|
PasswordManager = new OrganizationPasswordManagerRequestModel
|
|
{
|
|
Plan = PlanType.FamiliesAnnually,
|
|
SponsoredPlan = PlanSponsorshipType.FamiliesForEnterprise,
|
|
AdditionalStorage = 0
|
|
},
|
|
TaxInformation = new TaxInformationRequestModel
|
|
{
|
|
Country = "FR",
|
|
PostalCode = "12345"
|
|
}
|
|
};
|
|
|
|
sutProvider.GetDependency<IStripeAdapter>()
|
|
.InvoiceCreatePreviewAsync(Arg.Is<InvoiceCreatePreviewOptions>(p =>
|
|
p.Currency == "usd" &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == "2021-family-for-enterprise-annually" &&
|
|
x.Quantity == 1) &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == familiesPlan.PasswordManager.StripeStoragePlanId &&
|
|
x.Quantity == 0)))
|
|
.Returns(new Invoice
|
|
{
|
|
TotalExcludingTax = 0,
|
|
Tax = 0,
|
|
Total = 0
|
|
});
|
|
|
|
var actual = await sutProvider.Sut.PreviewInvoiceAsync(parameters, null, null);
|
|
|
|
Assert.Equal(0M, actual.TaxAmount);
|
|
Assert.Equal(0M, actual.TotalAmount);
|
|
Assert.Equal(0M, actual.TaxableBaseAmount);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PreviewInvoiceAsync_ForOrganization_CalculatesSalesTaxCorrectlyForFamiliesForEnterpriseWithAdditionalStorage(
|
|
SutProvider<StripePaymentService> sutProvider)
|
|
{
|
|
sutProvider.GetDependency<IAutomaticTaxFactory>()
|
|
.CreateAsync(Arg.Is<AutomaticTaxFactoryParameters>(p => p.PlanType == PlanType.FamiliesAnnually))
|
|
.Returns(new FakeAutomaticTaxStrategy(true));
|
|
|
|
var familiesPlan = new FamiliesPlan();
|
|
sutProvider.GetDependency<IPricingClient>()
|
|
.GetPlanOrThrow(Arg.Is<PlanType>(p => p == PlanType.FamiliesAnnually))
|
|
.Returns(familiesPlan);
|
|
|
|
var parameters = new PreviewOrganizationInvoiceRequestBody
|
|
{
|
|
PasswordManager = new OrganizationPasswordManagerRequestModel
|
|
{
|
|
Plan = PlanType.FamiliesAnnually,
|
|
SponsoredPlan = PlanSponsorshipType.FamiliesForEnterprise,
|
|
AdditionalStorage = 1
|
|
},
|
|
TaxInformation = new TaxInformationRequestModel
|
|
{
|
|
Country = "FR",
|
|
PostalCode = "12345"
|
|
}
|
|
};
|
|
|
|
sutProvider.GetDependency<IStripeAdapter>()
|
|
.InvoiceCreatePreviewAsync(Arg.Is<InvoiceCreatePreviewOptions>(p =>
|
|
p.Currency == "usd" &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == "2021-family-for-enterprise-annually" &&
|
|
x.Quantity == 1) &&
|
|
p.SubscriptionDetails.Items.Any(x =>
|
|
x.Plan == familiesPlan.PasswordManager.StripeStoragePlanId &&
|
|
x.Quantity == 1)))
|
|
.Returns(new Invoice
|
|
{
|
|
TotalExcludingTax = 400,
|
|
Tax = 8,
|
|
Total = 408
|
|
});
|
|
|
|
var actual = await sutProvider.Sut.PreviewInvoiceAsync(parameters, null, null);
|
|
|
|
Assert.Equal(0.08M, actual.TaxAmount);
|
|
Assert.Equal(4.08M, actual.TotalAmount);
|
|
Assert.Equal(4M, actual.TaxableBaseAmount);
|
|
}
|
|
}
|