nhyatt/go-bitbucket-v1
1
0
Fork 0
mirror of https://github.com/gfleury/go-bitbucket-v1.git synced 2025-04-05 09:18:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken Delete PullRequests

Browse Source
This commit is contained in:
gfleury 2020-03-17 15:00:19 -03:00
parent e4c8a88c87
commit 85968e42c6
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
default_api.go
View File

@ -1384,6 +1384,15 @@ func (a *DefaultApiService) Decline(projectKey, repositorySlug string, pullReque
/* DefaultApiService
Deletes a pull request. <p> To call this resource, users must be authenticated and have permission to view the pull request. Additionally, they must: <ul> <li> be the pull request author, if the system is configured to allow authors to delete their own pull requests (this is the default) OR </li> <li>have repository administrator permission for the repository the pull request is targeting</li> </ul> A body containing the version of the pull request must be provided with this request. <pre><code>{ \"version\": 1 }</code></pre>
@param pullRequestId the ID of the pull request within the repository
@return */
func (a *DefaultApiService) DeletePullRequest(projectKey, repositorySlug string, pullRequestID int64) (*APIResponse, error) {
return a.Delete(projectKey, repositorySlug, pullRequestID)
}
/* DefaultApiService
Deletes a pull request. <p> To call this resource, users must be authenticated and have permission to view the pull request. Additionally, they must: <ul> <li> be the pull request author, if the system is configured to allow authors to delete their own pull requests (this is the default) OR </li> <li>have repository administrator permission for the repository the pull request is targeting</li> </ul> A body containing the version of the pull request must be provided with this request. <pre><code>{ \"version\": 1 }</code></pre>
@param pullRequestId the ID of the pull request within the repository
@return */
func (a *DefaultApiService) Delete(projectKey, repositorySlug string, pullRequestID int64) (*APIResponse, error) {
@ -1394,6 +1403,10 @@ func (a *DefaultApiService) Delete(projectKey, repositorySlug string, pullReques
localVarFileBytes []byte
)
localVarPostBody = map[string]interface{}{
"version": 1,
}
// create path and map variables
localVarPath := a.client.cfg.BasePath + "/api/1.0/projects/{projectKey}/repos/{repositorySlug}/pull-requests/{pullRequestId}"
localVarPath = strings.Replace(localVarPath, "{"+"projectKey"+"}", fmt.Sprintf("%v", projectKey), -1)
@ -1405,7 +1418,7 @@ func (a *DefaultApiService) Delete(projectKey, repositorySlug string, pullReques
localVarFormParams := url.Values{}
// to determine the Content-Type header
localVarHTTPContentTypes := []string{}
localVarHTTPContentTypes := []string{"application/json"}
// set Content-Type header
localVarHTTPContentType := selectHeaderContentType(localVarHTTPContentTypes)

21
default_api_test.go
View File

@ -1113,6 +1113,26 @@ func TestDefaultApiService_Delete(t *testing.T) {
wantErr, integrationTest bool
}{
{"networkErrorContextExceeded", fields{client: generateConfigFake()}, args{}, &APIResponse{Message: "Delete https://stash.domain.com/rest/api/1.0/projects//repos//pull-requests/0: context canceled"}, true, false},
{"wrongType", fields{
client: generateConfigRealLocalServer()},
args{
projectKey: "PROJ",
repositorySlug: "repo1",
pullRequestID: -1,
},
&APIResponse{
Message: "Status: 404 , Body: {errors:[{context:null,message:No pull request exists with ID -1 for this repository 1,exceptionName:com.atlassian.bitbucket.pull.NoSuchPullRequestException}]}",
Values: map[string]interface{}{
"errors": []interface{}{
map[string]interface{}{
"context": nil,
"message": "No pull request exists with ID -1 for this repository 1",
"exceptionName": "com.atlassian.bitbucket.pull.NoSuchPullRequestException",
},
},
},
},
true, true},
}
for _, tt := range tests {
if tt.integrationTest != runIntegrationTests {
@ -1127,6 +1147,7 @@ func TestDefaultApiService_Delete(t *testing.T) {
t.Errorf("DefaultApiService.Delete() error = %v, wantErr %v", err, tt.wantErr)
return
}
got.Response = nil
if !reflect.DeepEqual(got, tt.want) {
t.Errorf("DefaultApiService.Delete() = %v, want %v", got, tt.want)
}