From 0fc43a220a249a32b5222d14389aeaf21bc30ac2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=ABl=20Stemmer?= Date: Thu, 11 Aug 2022 00:49:55 +0100 Subject: [PATCH] internal/gojunitreport: Refactor testFileConfig to drop else block --- internal/gojunitreport/go-junit-report_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/gojunitreport/go-junit-report_test.go b/internal/gojunitreport/go-junit-report_test.go index a44d67f..3f73809 100644 --- a/internal/gojunitreport/go-junit-report_test.go +++ b/internal/gojunitreport/go-junit-report_test.go @@ -86,12 +86,12 @@ func testRun(inputFile, reportFile string, config Config, t *testing.T) { } func testFileConfig(filename string) (config Config, reportFile string, err error) { - var prefix string - if idx := strings.IndexByte(filename, '-'); idx < 0 { + idx := strings.IndexByte(filename, '-') + if idx < 0 { return config, "", fmt.Errorf("testdata file does not contain a dash (-); expected name `{id}-{name}.txt` got `%s`", filename) - } else { - prefix = filename[:idx] } + + prefix := filename[:idx] id, err := strconv.Atoi(prefix) if err != nil { return config, "", fmt.Errorf("testdata file did not start with a valid number: %w", err)