nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 05:00:15 -05:00
Code Issues Projects Releases Wiki Activity

Fix incorrect diff error messages in tests

Browse Source
This commit is contained in:
Joël Stemmer 2022-03-31 23:08:54 +01:00
parent 044e2fc120
commit 125573d6fc
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
go-junit-report_test.go
View File

@ -102,7 +102,7 @@ func testRun(inputFile, reportFile string, config TestConfig, t *testing.T) {
} }
if diff := cmp.Diff(output.String(), string(wantReport)); diff != "" { if diff := cmp.Diff(output.String(), string(wantReport)); diff != "" {
t.Errorf("Unexpected report diff (-got, +want):\n%v", diff) t.Errorf("Unexpected report diff (-want, +got):\n%v", diff)
} }
} }

4
pkg/parser/gotest/gotest_test.go
View File

@ -208,7 +208,7 @@ func TestParseLine(t *testing.T) {
parser.parseLine(test.input) parser.parseLine(test.input)
got := parser.events got := parser.events
if diff := cmp.Diff(got, want); diff != "" { if diff := cmp.Diff(got, want); diff != "" {
t.Errorf("parseLine(%q) returned unexpected events, diff (-got, +want):\n%v", test.input, diff) t.Errorf("parseLine(%q) returned unexpected events, diff (-want, +got):\n%v", test.input, diff)
} }
}) })
} }
@ -310,6 +310,6 @@ func TestReport(t *testing.T) {
parser := New(TimestampFunc(func() time.Time { return testTimestamp })) parser := New(TimestampFunc(func() time.Time { return testTimestamp }))
actual := parser.report(events) actual := parser.report(events)
if diff := cmp.Diff(actual, expected); diff != "" { if diff := cmp.Diff(actual, expected); diff != "" {
t.Errorf("FromEvents report incorrect, diff (-got, +want):\n%v", diff) t.Errorf("FromEvents report incorrect, diff (-want, +got):\n%v", diff)
} }
} }

6
pkg/parser/gotest/json_test.go
View File

@ -25,7 +25,7 @@ func TestJSONReaderReadAll(t *testing.T) {
` `
if diff := cmp.Diff(string(got), want); diff != "" { if diff := cmp.Diff(string(got), want); diff != "" {
t.Errorf("unexpected result from jsonReader, diff (-got, +want):\n%s\n", diff) t.Errorf("unexpected result from jsonReader, diff (-want, +got):\n%s\n", diff)
} }
} }
@ -52,12 +52,12 @@ func TestJSONReaderReadSmallBuffer(t *testing.T) {
} }
if diff := cmp.Diff(string(buf[:n]), string(want)); diff != "" { if diff := cmp.Diff(string(buf[:n]), string(want)); diff != "" {
t.Fatalf("unexpected result from jsonReader, diff (-got, +want):\n%s\n", diff) t.Fatalf("unexpected result from jsonReader, diff (-want, +got):\n%s\n", diff)
} }
} }
_, err := r.Read(buf) _, err := r.Read(buf)
if err != io.EOF { if err != io.EOF {
t.Fatalf("unexpected result from jsonReader: got %v, want %v", err, io.EOF) t.Fatalf("unexpected error from jsonReader: got %v, want %v", err, io.EOF)
} }
} }