Addressing code review comments.

Mainly:
* Moving the averaging/merging of benchmarks from the parser to the formatter package
* Tightening up the regex so it only captures the numeric values (no more of trimming spaces and the ns/op)
* Deleting the writing up in xml file the benchmark memory sections of B/op and Allocs/op

Also added a test case for parseNanoseconds().
This commit is contained in:
Brittany Walentin
2018-05-25 10:59:00 -07:00
parent b2f467b67c
commit 260b47cabe
9 changed files with 185 additions and 128 deletions

View File

@ -4,7 +4,7 @@
<properties>
<property name="go.version" value="1.0"></property>
</properties>
<testcase classname="one" name="BenchmarkIpsHistoryInsert" time="0.000052568" bytes="24879" allocs="494"></testcase>
<testcase classname="one" name="BenchmarkIpsHistoryLookup" time="0.000015208" bytes="7369" allocs="143"></testcase>
<testcase classname="one" name="BenchmarkIpsHistoryInsert" time="0.000052568"></testcase>
<testcase classname="one" name="BenchmarkIpsHistoryLookup" time="0.000015208"></testcase>
</testsuite>
</testsuites>

View File

@ -8,7 +8,7 @@
<testcase classname="baz" name="TestNew/no" time="0.000"></testcase>
<testcase classname="baz" name="TestNew/normal" time="0.000"></testcase>
<testcase classname="baz" name="TestWriteThis" time="0.000"></testcase>
<testcase classname="baz" name="BenchmarkDeepMerge" time="0.000002611" bytes="1110" allocs="16"></testcase>
<testcase classname="baz" name="BenchmarkNext" time="0.000000100" bytes="100" allocs="1"></testcase>
<testcase classname="baz" name="BenchmarkDeepMerge" time="0.000002611"></testcase>
<testcase classname="baz" name="BenchmarkNext" time="0.000000100"></testcase>
</testsuite>
</testsuites>

View File

@ -1,10 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
<testsuite tests="2" failures="0" time="14.211" name="pkg/count">
<testsuite tests="10" failures="0" time="14.211" name="pkg/count">
<properties>
<property name="go.version" value="1.0"></property>
</properties>
<testcase classname="count" name="BenchmarkNew" time="0.000000352" bytes="80" allocs="3"></testcase>
<testcase classname="count" name="BenchmarkFew" time="0.000000102" bytes="20" allocs="1"></testcase>
<testcase classname="count" name="BenchmarkNew" time="0.000000352"></testcase>
<testcase classname="count" name="BenchmarkFew" time="0.000000102"></testcase>
</testsuite>
</testsuites>

View File

@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
<testsuite tests="7" failures="0" time="14.211" name="multiple/repeating">
<testsuite tests="15" failures="0" time="14.211" name="multiple/repeating">
<properties>
<property name="go.version" value="1.0"></property>
</properties>
@ -9,7 +9,7 @@
<testcase classname="repeating" name="TestRepeat" time="0.000"></testcase>
<testcase classname="repeating" name="TestRepeat" time="0.000"></testcase>
<testcase classname="repeating" name="TestRepeat" time="0.000"></testcase>
<testcase classname="repeating" name="BenchmarkNew" time="0.000000352" bytes="80" allocs="3"></testcase>
<testcase classname="repeating" name="BenchmarkFew" time="0.000000102" bytes="20" allocs="1"></testcase>
<testcase classname="repeating" name="BenchmarkNew" time="0.000000352"></testcase>
<testcase classname="repeating" name="BenchmarkFew" time="0.000000102"></testcase>
</testsuite>
</testsuites>