From 334044509c4b5377a16e7e063a1812abccea3ff7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=ABl=20Stemmer?= <stemmertech@gmail.com>
Date: Sun, 13 Mar 2022 21:26:28 +0000
Subject: [PATCH] Remove custom properties parsed from test output

In the future it will be possible to add your own properties via
commandline flags.
---
 go-junit-report_test.go | 16 ----------------
 pkg/gtr/gtr.go          | 11 -----------
 2 files changed, 27 deletions(-)

diff --git a/go-junit-report_test.go b/go-junit-report_test.go
index 30dfd78..bc6d666 100644
--- a/go-junit-report_test.go
+++ b/go-junit-report_test.go
@@ -205,8 +205,6 @@ func testReport(input, reportFile, packageName string, t *testing.T) {
 
 	testTime := time.Date(2022, 1, 1, 0, 0, 0, 0, time.UTC)
 	actual := gtr.JUnit(gtr.FromEvents(events, packageName), "hostname", testTime)
-	// Remove any new properties for backwards compatibility
-	actual = dropNewProperties(actual)
 
 	expectedXML, err := loadTestReport(reportFile, "")
 	if err != nil {
@@ -242,20 +240,6 @@ func modifyForBackwardsCompat(testsuites junit.Testsuites) junit.Testsuites {
 	return testsuites
 }
 
-func dropNewProperties(testsuites junit.Testsuites) junit.Testsuites {
-	for i, suite := range testsuites.Suites {
-		if suite.Properties == nil {
-			continue
-		}
-		ps := suite.Properties
-		ps = dropProperty("goos", ps)
-		ps = dropProperty("goarch", ps)
-		ps = dropProperty("pkg", ps)
-		testsuites.Suites[i].Properties = ps
-	}
-	return testsuites
-}
-
 func dropProperty(name string, properties *[]junit.Property) *[]junit.Property {
 	if properties == nil {
 		return nil
diff --git a/pkg/gtr/gtr.go b/pkg/gtr/gtr.go
index e5e4ed6..e929157 100644
--- a/pkg/gtr/gtr.go
+++ b/pkg/gtr/gtr.go
@@ -10,11 +10,6 @@ import (
 	"github.com/jstemmer/go-junit-report/v2/pkg/junit"
 )
 
-var (
-	propPrefixes   = map[string]bool{"goos": true, "goarch": true, "pkg": true}
-	propFieldsFunc = func(r rune) bool { return r == ':' || r == ' ' }
-)
-
 type Report struct {
 	Packages []Package
 }
@@ -126,12 +121,6 @@ func JUnit(report Report, hostname string, now time.Time) junit.Testsuites {
 			suite.AddProperty("coverage.statements.pct", fmt.Sprintf("%.2f", pkg.Coverage))
 		}
 
-		for _, line := range pkg.Output {
-			if fields := strings.FieldsFunc(line, propFieldsFunc); len(fields) == 2 && propPrefixes[fields[0]] {
-				suite.AddProperty(fields[0], fields[1])
-			}
-		}
-
 		for _, test := range pkg.Tests {
 			duration += test.Duration