Fail package in case of build error

In case of build error, the unittest fail, but the junit-report
with the set-exit-code flag on returns status code 0.
This commit will make it return the right status code.
This commit is contained in:
Eyal Posener 2017-01-22 02:12:25 +02:00
parent 6aeed679b6
commit 3c05bc8cb6
5 changed files with 95 additions and 33 deletions

View File

@ -37,7 +37,7 @@ func main() {
os.Exit(1)
}
if setExitCode && report.Failures() > 0 {
if setExitCode && report.Failed() {
os.Exit(1)
}
}

View File

@ -29,6 +29,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 160,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestZ",
@ -55,6 +56,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 151,
Result: parser.FAIL,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -86,6 +88,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 150,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -114,6 +117,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 160,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -140,6 +144,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 160,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -167,6 +172,7 @@ var testCases = []TestCase{
{
Name: "package/name1",
Time: 160,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -185,6 +191,7 @@ var testCases = []TestCase{
{
Name: "package/name2",
Time: 151,
Result: parser.FAIL,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -217,6 +224,7 @@ var testCases = []TestCase{
{
Name: "test/package",
Time: 160,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -244,6 +252,7 @@ var testCases = []TestCase{
{
Name: "github.com/dmitris/test-go-junit-report",
Time: 440,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestDoFoo",
@ -270,6 +279,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 160,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestZ",
@ -297,6 +307,7 @@ var testCases = []TestCase{
{
Name: "package1/foo",
Time: 400,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestA",
@ -316,6 +327,7 @@ var testCases = []TestCase{
{
Name: "package2/bar",
Time: 4200,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestC",
@ -337,6 +349,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 50,
Result: parser.PASS,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -363,6 +376,7 @@ var testCases = []TestCase{
{
Name: "package/name",
Time: 50,
Result: parser.FAIL,
Tests: []*parser.Test{
{
Name: "TestOne",
@ -487,6 +501,19 @@ var testCases = []TestCase{
},
},
},
{
name: "13-syntax-error.txt",
reportName: "13-report.xml",
report: &parser.Report{
Packages: []parser.Package{
{
Name: "package/name",
Result: parser.FAIL,
Tests: []*parser.Test{},
},
},
},
},
}
func TestParser(t *testing.T) {

View File

@ -29,6 +29,7 @@ type Package struct {
Time int
Tests []*Test
CoveragePct string
Result Result
}
// Test contains the results of a single test.
@ -43,6 +44,7 @@ var (
regexStatus = regexp.MustCompile(`^\s*--- (PASS|FAIL|SKIP): (.+) \((\d+\.\d+)(?: seconds|s)\)$`)
regexCoverage = regexp.MustCompile(`^coverage:\s+(\d+\.\d+)%\s+of\s+statements$`)
regexResult = regexp.MustCompile(`^(ok|FAIL)\s+(.+)\s(\d+\.\d+)s(?:\s+coverage:\s+(\d+\.\d+)%\s+of\s+statements)?$`)
regexBuildFailure = regexp.MustCompile(`^FAIL\s+(.+)\s\[build failed]$`)
regexOutput = regexp.MustCompile(`( )*\t(.*)`)
)
@ -66,6 +68,9 @@ func Parse(r io.Reader, pkgName string) (*Report, error) {
// coverage percentage report for current package
var coveragePct string
// whole package test result
packageResult := FAIL
// parse lines
for {
l, _, err := reader.ReadLine()
@ -88,6 +93,9 @@ func Parse(r io.Reader, pkgName string) (*Report, error) {
} else if matches := regexResult.FindStringSubmatch(line); len(matches) == 5 {
if matches[4] != "" {
coveragePct = matches[4]
if matches[0] == "ok" {
packageResult = PASS
}
}
// all tests in this package are finished
@ -96,12 +104,19 @@ func Parse(r io.Reader, pkgName string) (*Report, error) {
Time: parseTime(matches[3]),
Tests: tests,
CoveragePct: coveragePct,
Result: packageResult,
})
tests = make([]*Test, 0)
coveragePct = ""
cur = ""
testsTime = 0
} else if matches := regexBuildFailure.FindStringSubmatch(line); len(matches) == 2 {
report.Packages = append(report.Packages, Package{
Name: matches[1],
Result: FAIL,
})
} else if matches := regexStatus.FindStringSubmatch(line); len(matches) == 4 {
cur = matches[2]
test := findTest(tests, cur)
@ -143,6 +158,7 @@ func Parse(r io.Reader, pkgName string) (*Report, error) {
Time: testsTime,
Tests: tests,
CoveragePct: coveragePct,
Result: packageResult,
})
}
@ -180,3 +196,12 @@ func (r *Report) Failures() int {
return count
}
func (r *Report) Failed() bool {
for _, p := range r.Packages {
if p.Result == FAIL {
return true
}
}
return false
}

8
tests/13-report.xml Normal file
View File

@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
<testsuite tests="0" failures="0" time="0.000" name="package/name">
<properties>
<property name="go.version" value="1.0"></property>
</properties>
</testsuite>
</testsuites>

View File

@ -0,0 +1,2 @@
package/name/file_test.go:9: undefined: x
FAIL package/name [build failed]