From 4fdb6ca5645036dfe66ec3f4fc286f6562fe62e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=ABl=20Stemmer?= <stemmertech@gmail.com>
Date: Mon, 7 Oct 2019 01:17:20 +0100
Subject: [PATCH] gtr: Move tests from build and runtime errors to end of junit
 report

---
 pkg/gtr/gtr.go | 58 +++++++++++++++++++++++++-------------------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/pkg/gtr/gtr.go b/pkg/gtr/gtr.go
index 7d3d8f2..c8815a1 100644
--- a/pkg/gtr/gtr.go
+++ b/pkg/gtr/gtr.go
@@ -118,35 +118,6 @@ func JUnit(report Report) junit.Testsuites {
 			}
 		}
 
-		// JUnit doesn't have a good way of dealing with build or runtime
-		// errors that happen before a test has started, so we create a single
-		// failing test that contains the build error details.
-		if pkg.BuildError.Name != "" {
-			tc := junit.Testcase{
-				Classname: pkg.BuildError.Name,
-				Name:      pkg.BuildError.Cause,
-				Time:      junit.FormatDuration(0),
-				Failure: &junit.Result{
-					Message: "Failed",
-					Data:    strings.Join(pkg.BuildError.Output, "\n"),
-				},
-			}
-			suite.AddTestcase(tc)
-		}
-
-		if pkg.RunError.Name != "" {
-			tc := junit.Testcase{
-				Classname: pkg.RunError.Name,
-				Name:      "Failure",
-				Time:      junit.FormatDuration(0),
-				Failure: &junit.Result{
-					Message: "Failed",
-					Data:    strings.Join(pkg.RunError.Output, "\n"),
-				},
-			}
-			suite.AddTestcase(tc)
-		}
-
 		for _, test := range pkg.Tests {
 			duration += test.Duration
 
@@ -186,6 +157,35 @@ func JUnit(report Report) junit.Testsuites {
 			suite.AddTestcase(tc)
 		}
 
+		// JUnit doesn't have a good way of dealing with build or runtime
+		// errors that happen before a test has started, so we create a single
+		// failing test that contains the build error details.
+		if pkg.BuildError.Name != "" {
+			tc := junit.Testcase{
+				Classname: pkg.BuildError.Name,
+				Name:      pkg.BuildError.Cause,
+				Time:      junit.FormatDuration(0),
+				Failure: &junit.Result{
+					Message: "Failed",
+					Data:    strings.Join(pkg.BuildError.Output, "\n"),
+				},
+			}
+			suite.AddTestcase(tc)
+		}
+
+		if pkg.RunError.Name != "" {
+			tc := junit.Testcase{
+				Classname: pkg.RunError.Name,
+				Name:      "Failure",
+				Time:      junit.FormatDuration(0),
+				Failure: &junit.Result{
+					Message: "Failed",
+					Data:    strings.Join(pkg.RunError.Output, "\n"),
+				},
+			}
+			suite.AddTestcase(tc)
+		}
+
 		if (pkg.Duration) == 0 {
 			suite.Time = junit.FormatDuration(duration)
 		} else {