From 63c2422f96fccd16f261aaa0ec1411ffbb737db8 Mon Sep 17 00:00:00 2001 From: Mark Rushakoff Date: Thu, 13 Dec 2018 11:41:34 -0800 Subject: [PATCH] Reject positional CLI arguments My team spent a bit of time debugging a mistake where we forgot to redirect output to a file. The command looked valid and exited 0. This change causes the program to fail if provided with any positional arguments. --- go-junit-report.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/go-junit-report.go b/go-junit-report.go index 5c2e433..43ff964 100644 --- a/go-junit-report.go +++ b/go-junit-report.go @@ -26,6 +26,11 @@ func init() { func main() { flag.Parse() + if flag.NArg() != 0 { + fmt.Println("go-junit-report does not accept positional arguments") + os.Exit(1) + } + // Read input report, err := parser.Parse(os.Stdin, packageName) if err != nil {