nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 05:00:15 -05:00
Code Issues Projects Releases Wiki Activity

gtr: Handle end_test events without corresponding run_test event

Browse Source 
When running `go test` without the `-v` flag, the output may not contain
everything that we expect. For example, no output is generated for
passing tests. Even for a failing test the output does not contain a
`=== RUN` line.

Currently, this resulted in us ignoring the test result since we
couldn't find an existing test to assign this result to. We should
however handle this situation gracefully, and just assume a test exists
when only encountering a test result line.

References #109
This commit is contained in:
Joël Stemmer 2022-02-27 22:08:50 +00:00
parent 014828bef4
commit 817a23b10d
6 changed files with 41 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/gtr/builder.go
View File

@ -68,14 +68,19 @@ func (b *ReportBuilder) ContinueTest(name string) {
} }
func (b *ReportBuilder) EndTest(name, result string, duration time.Duration, level int) { func (b *ReportBuilder) EndTest(name, result string, duration time.Duration, level int) {
id := b.findTest(name) b.lastId = b.findTest(name)
b.lastId = id if b.lastId < 0 {
// test did not exist, create one
// TODO: Likely reason is that the user ran go test without the -v
// flag, should we report this somewhere?
b.CreateTest(name)
}
t := b.tests[id] t := b.tests[b.lastId]
t.Result = parseResult(result) t.Result = parseResult(result)
t.Duration = duration t.Duration = duration
t.Level = level t.Level = level
b.tests[id] = t b.tests[b.lastId] = t
} }
func (b *ReportBuilder) End() { func (b *ReportBuilder) End() {
@ -229,7 +234,7 @@ func (b *ReportBuilder) findBenchmark(name string) int {
func (b *ReportBuilder) containsFailingTest() bool { func (b *ReportBuilder) containsFailingTest() bool {
for _, test := range b.tests { for _, test := range b.tests {
if test.Result == Fail { if test.Result == Fail || test.Result == Unknown {
return true return true
} }
} }

13
pkg/gtr/gtr.go
View File

@ -143,6 +143,11 @@ func JUnit(report Report, hostname string, now time.Time) junit.Testsuites {
tc.Skipped = &junit.Result{ tc.Skipped = &junit.Result{
Message: formatOutput(test.Output, test.Level), Message: formatOutput(test.Output, test.Level),
} }
} else if test.Result == Unknown {
tc.Error = &junit.Result{
Message: "No test result found",
Data: formatOutput(test.Output, test.Level),
}
} }
suite.AddTestcase(tc) suite.AddTestcase(tc)
@ -172,8 +177,8 @@ func JUnit(report Report, hostname string, now time.Time) junit.Testsuites {
Classname: pkg.BuildError.Name, Classname: pkg.BuildError.Name,
Name: pkg.BuildError.Cause, Name: pkg.BuildError.Cause,
Time: junit.FormatDuration(0), Time: junit.FormatDuration(0),
Failure: &junit.Result{ Error: &junit.Result{
Message: "Failed", Message: "Build error",
Data: strings.Join(pkg.BuildError.Output, "\n"), Data: strings.Join(pkg.BuildError.Output, "\n"),
}, },
} }
@ -185,8 +190,8 @@ func JUnit(report Report, hostname string, now time.Time) junit.Testsuites {
Classname: pkg.RunError.Name, Classname: pkg.RunError.Name,
Name: "Failure", Name: "Failure",
Time: junit.FormatDuration(0), Time: junit.FormatDuration(0),
Failure: &junit.Result{ Error: &junit.Result{
Message: "Failed", Message: "Run error",
Data: strings.Join(pkg.RunError.Output, "\n"), Data: strings.Join(pkg.RunError.Output, "\n"),
}, },
} }

14
testdata/13-report.xml vendored
View File

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="5" failures="3"> <testsuites tests="5" errors="3">
<testsuite tests="1" failures="0" errors="0" time="0.100" name="package/name/passing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="0" time="0.100" name="package/name/passing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
@ -12,28 +12,28 @@
</properties> </properties>
<testcase classname="passing2" name="TestB" time="0.100"></testcase> <testcase classname="passing2" name="TestB" time="0.100"></testcase>
</testsuite> </testsuite>
<testsuite tests="1" failures="1" errors="0" time="0.000" name="package/name/failing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.000" name="package/name/failing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="failing1" name="[build failed]" time="0.000"> <testcase classname="failing1" name="[build failed]" time="0.000">
<failure message="Failed" type="">failing1/failing_test.go:15: undefined: x</failure> <error message="Build error" type="">failing1/failing_test.go:15: undefined: x</error>
</testcase> </testcase>
</testsuite> </testsuite>
<testsuite tests="1" failures="1" errors="0" time="0.000" name="package/name/failing2" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.000" name="package/name/failing2" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="failing2" name="[build failed]" time="0.000"> <testcase classname="failing2" name="[build failed]" time="0.000">
<failure message="Failed" type="">failing2/another_failing_test.go:20: undefined: y</failure> <error message="Build error" type="">failing2/another_failing_test.go:20: undefined: y</error>
</testcase> </testcase>
</testsuite> </testsuite>
<testsuite tests="1" failures="1" errors="0" time="0.000" name="package/name/setupfailing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.000" name="package/name/setupfailing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="setupfailing1" name="[setup failed]" time="0.000"> <testcase classname="setupfailing1" name="[setup failed]" time="0.000">
<failure message="Failed" type="">setupfailing1/failing_test.go:4: cannot find package &#34;other/package&#34; in any of:&#xA;&#x9;/path/vendor (vendor tree)&#xA;&#x9;/path/go/root (from $GOROOT)&#xA;&#x9;/path/go/path (from $GOPATH)</failure> <error message="Build error" type="">setupfailing1/failing_test.go:4: cannot find package &#34;other/package&#34; in any of:&#xA;&#x9;/path/vendor (vendor tree)&#xA;&#x9;/path/go/root (from $GOROOT)&#xA;&#x9;/path/go/path (from $GOPATH)</error>
</testcase> </testcase>
</testsuite> </testsuite>
</testsuites> </testsuites>

10
testdata/14-report.xml vendored
View File

@ -1,19 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="2" failures="2"> <testsuites tests="2" errors="2">
<testsuite tests="1" failures="1" errors="0" time="0.003" name="package/panic" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.003" name="package/panic" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="panic" name="Failure" time="0.000"> <testcase classname="panic" name="Failure" time="0.000">
<failure message="Failed" type="">panic: init&#xA;stacktrace</failure> <error message="Run error" type="">panic: init&#xA;stacktrace</error>
</testcase> </testcase>
</testsuite> </testsuite>
<testsuite tests="1" failures="1" errors="0" time="0.003" name="package/panic2" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.003" name="package/panic2" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="panic2" name="Failure" time="0.000"> <testcase classname="panic2" name="Failure" time="0.000">
<failure message="Failed" type="">panic: init&#xA;stacktrace</failure> <error message="Run error" type="">panic: init&#xA;stacktrace</error>
</testcase> </testcase>
</testsuite> </testsuite>
</testsuites> </testsuites>

14
testdata/31-report.xml vendored
View File

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="5" failures="3"> <testsuites tests="5" errors="3">
<testsuite tests="1" failures="0" errors="0" time="0.100" name="package/name/passing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="0" time="0.100" name="package/name/passing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
@ -12,28 +12,28 @@
</properties> </properties>
<testcase classname="passing2" name="TestB" time="0.100"></testcase> <testcase classname="passing2" name="TestB" time="0.100"></testcase>
</testsuite> </testsuite>
<testsuite tests="1" failures="1" errors="0" time="0.000" name="package/name/failing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.000" name="package/name/failing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="failing1" name="[build failed]" time="0.000"> <testcase classname="failing1" name="[build failed]" time="0.000">
<failure message="Failed" type="">failing1/failing_test.go:15: undefined: x</failure> <error message="Build error" type="">failing1/failing_test.go:15: undefined: x</error>
</testcase> </testcase>
</testsuite> </testsuite>
<testsuite tests="1" failures="1" errors="0" time="0.000" name="package/name/failing2" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.000" name="package/name/failing2" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="failing2" name="[build failed]" time="0.000"> <testcase classname="failing2" name="[build failed]" time="0.000">
<failure message="Failed" type="">failing2/another_failing_test.go:20: undefined: y</failure> <error message="Build error" type="">failing2/another_failing_test.go:20: undefined: y</error>
</testcase> </testcase>
</testsuite> </testsuite>
<testsuite tests="1" failures="1" errors="0" time="0.000" name="package/name/setupfailing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="1" failures="0" errors="1" time="0.000" name="package/name/setupfailing1" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="setupfailing1" name="[setup failed]" time="0.000"> <testcase classname="setupfailing1" name="[setup failed]" time="0.000">
<failure message="Failed" type="">setupfailing1/failing_test.go:4: cannot find package &#34;other/package&#34; in any of:&#xA;&#x9;/path/vendor (vendor tree)&#xA;&#x9;/path/go/root (from $GOROOT)&#xA;&#x9;/path/go/path (from $GOPATH)</failure> <error message="Build error" type="">setupfailing1/failing_test.go:4: cannot find package &#34;other/package&#34; in any of:&#xA;&#x9;/path/vendor (vendor tree)&#xA;&#x9;/path/go/root (from $GOROOT)&#xA;&#x9;/path/go/path (from $GOPATH)</error>
</testcase> </testcase>
</testsuite> </testsuite>
</testsuites> </testsuites>

6
testdata/32-report.xml vendored
View File

@ -1,12 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="2" failures="1"> <testsuites tests="2" errors="1">
<testsuite tests="2" failures="1" errors="0" time="0.005" name="github.com/jstemmer/test/failedsummary" hostname="hostname" timestamp="2022-01-01T00:00:00Z"> <testsuite tests="2" failures="0" errors="1" time="0.005" name="github.com/jstemmer/test/failedsummary" hostname="hostname" timestamp="2022-01-01T00:00:00Z">
<properties> <properties>
<property name="go.version" value="1.0"></property> <property name="go.version" value="1.0"></property>
</properties> </properties>
<testcase classname="failedsummary" name="TestOne" time="0.000"></testcase> <testcase classname="failedsummary" name="TestOne" time="0.000"></testcase>
<testcase classname="failedsummary" name="Failure" time="0.000"> <testcase classname="failedsummary" name="Failure" time="0.000">
<failure message="Failed" type="">panic: panic</failure> <error message="Run error" type="">panic: panic</error>
</testcase> </testcase>
</testsuite> </testsuite>
</testsuites> </testsuites>