From 884279de84a0fb02593e1d41040f6e0ac0365a3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=ABl=20Stemmer?= Date: Sun, 6 Mar 2022 14:53:21 +0000 Subject: [PATCH] Deprecate the `-go-version` flag The `-go-version` flag is used to set the `go.version` property in the generated XML file. In v2 we no longer want a flag dedicated to a specific property. Instead, the -prop flag has been introduced to set arbitrary properties in the generated report. If the `-go-version` flag is set, we'll still add a `go.version` property to the report but also print a warning. This flag will be removed completely in the future. --- go-junit-report.go | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/go-junit-report.go b/go-junit-report.go index 9375eb1..531faba 100644 --- a/go-junit-report.go +++ b/go-junit-report.go @@ -21,18 +21,20 @@ var ( ) var ( - noXMLHeader = flag.Bool("no-xml-header", false, "do not print xml header") - packageName = flag.String("package-name", "", "specify a package name (compiled test have no package name in output)") - goVersionFlag = flag.String("go-version", "", "specify the value to use for the go.version property in the generated XML") - setExitCode = flag.Bool("set-exit-code", false, "set exit code to 1 if tests failed") - version = flag.Bool("version", false, "print version") - input = flag.String("in", "", "read go test log from file") - output = flag.String("out", "", "write XML report to file") - iocopy = flag.Bool("iocopy", false, "copy input to stdout; can only be used in conjunction with -out") - properties = make(keyValueFlag) + noXMLHeader = flag.Bool("no-xml-header", false, "do not print xml header") + packageName = flag.String("package-name", "", "specify a package name (compiled test have no package name in output)") + setExitCode = flag.Bool("set-exit-code", false, "set exit code to 1 if tests failed") + version = flag.Bool("version", false, "print version") + input = flag.String("in", "", "read go test log from file") + output = flag.String("out", "", "write XML report to file") + iocopy = flag.Bool("iocopy", false, "copy input to stdout; can only be used in conjunction with -out") + properties = make(keyValueFlag) // debug flags printEvents = flag.Bool("debug.print-events", false, "print events generated by the go test parser") + + // deprecated flags + goVersionFlag = flag.String("go-version", "", "(deprecated, use -prop) the value to use for the go.version property in the generated XML") ) func main() { @@ -47,6 +49,11 @@ func main() { return } + if *goVersionFlag != "" { + fmt.Fprintf(os.Stderr, "the -go-version flag is deprecated and will be removed in the future.\n") + properties["go.version"] = *goVersionFlag + } + if flag.NArg() != 0 { fmt.Fprintf(os.Stderr, "%s does not accept positional arguments\n", os.Args[0]) flag.Usage()