nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-08 06:28:08 -05:00
Code Issues Projects Releases Wiki Activity

Do not create <failure> tag when message is empty

Browse Source
This commit is contained in:
Joel Stemmer 2012-03-16 15:41:19 +01:00
parent 92be560b6c
commit 8cf088e24f
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
junit-formatter.go
View File

@ -22,7 +22,7 @@ type JUnitTestCase struct {
Classname string `xml:"classname,attr"` Classname string `xml:"classname,attr"`
Name string `xml:"name,attr"` Name string `xml:"name,attr"`
Time string `xml:"time,attr"` Time string `xml:"time,attr"`
Failure *string `xml:"failure"` Failure string `xml:"failure,omitempty"`
} }
func JUnitReportXML(report *Report, w io.Writer) error { func JUnitReportXML(report *Report, w io.Writer) error {
@ -49,15 +49,14 @@ func JUnitReportXML(report *Report, w io.Writer) error {
Classname: classname, Classname: classname,
Name: test.Name, Name: test.Name,
Time: formatTime(test.Time), Time: formatTime(test.Time),
Failure: nil, Failure: "",
} }
if test.Result == FAIL { if test.Result == FAIL {
ts.Failures += 1 ts.Failures += 1
// TODO: set error message // TODO: set error message
msg := "" testCase.Failure = ""
testCase.Failure = &msg
} }
ts.TestCases = append(ts.TestCases, testCase) ts.TestCases = append(ts.TestCases, testCase)

4
tests/02-report.xml
View File

@ -1,7 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<testsuite tests="2" failures="1" time="0.151" name="package/name"> <testsuite tests="2" failures="1" time="0.151" name="package/name">
<testcase classname="name" name="TestOne" time="0.020"> <testcase classname="name" name="TestOne" time="0.020"></testcase>
<failure></failure>
</testcase>
<testcase classname="name" name="TestTwo" time="0.130"></testcase> <testcase classname="name" name="TestTwo" time="0.130"></testcase>
</testsuite> </testsuite>