nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 05:00:15 -05:00
Code Issues Projects Releases Wiki Activity

parser/gotest: Handle build errors in test packages with _test suffix

Browse Source 
It's possible for test files to declare a package with the "_test"
suffix. If these packages contain build errors, they were not correctly
matched to the package without the "_test" suffix.

Refs #145
This commit is contained in:
Joël Stemmer 2022-09-17 01:05:30 +01:00
parent 81e5aaaaf1
commit 97e0285183
4 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
parser/gotest/report_builder.go
View File

@ -150,7 +150,7 @@ func (b *reportBuilder) CreatePackage(packageName, newPackageName, result string
// First check if this package contained a build error. If that's the case, // First check if this package contained a build error. If that's the case,
// we won't find any tests in this package. // we won't find any tests in this package.
for id, buildErr := range b.buildErrors { for id, buildErr := range b.buildErrors {
if buildErr.Name == newPackageName { if buildErr.Name == newPackageName || strings.TrimSuffix(buildErr.Name, "_test") == newPackageName {
pkg.BuildError = buildErr pkg.BuildError = buildErr
pkg.BuildError.ID = id pkg.BuildError.ID = id
pkg.BuildError.Duration = duration pkg.BuildError.Duration = duration

20
parser/gotest/report_builder_test.go
View File

@ -392,6 +392,26 @@ func TestReportSpecialCases(t *testing.T) {
}, },
}, },
}, },
{
"build error in package with _test suffix",
[]Event{
{Type: "build_output", Name: "package/name_test"},
{Type: "summary", Name: "package/name", Result: "FAIL", Data: "[build failed]"},
},
gtr.Report{
Packages: []gtr.Package{
{
Name: "package/name",
Timestamp: testTimestamp,
BuildError: gtr.Error{
ID: 1,
Name: "package/name_test",
Cause: "[build failed]",
},
},
},
},
},
} }
for _, test := range tests { for _, test := range tests {

11
testdata/038-report.xml vendored Normal file
View File

@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="1" errors="1">
<testsuite name="package/testpkg/pkg" tests="1" failures="0" errors="1" id="0" hostname="hostname" time="0.000" timestamp="2022-01-01T00:00:00Z">
<properties>
<property name="go.version" value="1.0"></property>
</properties>
<testcase name="[build failed]" classname="package/testpkg/pkg_test" time="0.000">
<error message="Build error"><![CDATA[pkg/pkg_test.go:5:2: imported and not used: "fmt"]]></error>
</testcase>
</testsuite>
</testsuites>

4
testdata/038-test-pkg-name.txt vendored Normal file
View File

@ -0,0 +1,4 @@
# package/testpkg/pkg_test [package/testpkg/pkg.test]
pkg/pkg_test.go:5:2: imported and not used: "fmt"
FAIL package/testpkg/pkg [build failed]
FAIL