From 2a5fd0eeb0be54871f5c2090b820eef1fca684be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=ABl=20Stemmer?= Date: Thu, 27 Apr 2017 23:19:32 +0100 Subject: [PATCH] Include failing packages without tests in report If a package compiles correctly, but panics before it has a chance to run any tests it would previously be ignored. Any failing packages without tests but with some output will now be included in the report with a dummy test. Fixes #52 --- go-junit-report_test.go | 49 +++++++++++++++++++++++++++++++++++++++++ parser/parser.go | 16 ++++++++++++++ tests/14-panic.txt | 6 +++++ tests/14-report.xml | 19 ++++++++++++++++ tests/15-empty.txt | 3 +++ tests/15-report.xml | 8 +++++++ 6 files changed, 101 insertions(+) create mode 100644 tests/14-panic.txt create mode 100644 tests/14-report.xml create mode 100644 tests/15-empty.txt create mode 100644 tests/15-report.xml diff --git a/go-junit-report_test.go b/go-junit-report_test.go index f708c57..cb315c1 100644 --- a/go-junit-report_test.go +++ b/go-junit-report_test.go @@ -561,6 +561,55 @@ var testCases = []TestCase{ }, }, }, + { + name: "14-panic.txt", + reportName: "14-report.xml", + report: &parser.Report{ + Packages: []parser.Package{ + { + Name: "package/panic", + Time: 3, + Tests: []*parser.Test{ + { + Name: "Failure", + Result: parser.FAIL, + Output: []string{ + "panic: init", + "stacktrace", + }, + }, + }, + }, + { + Name: "package/panic2", + Time: 3, + Tests: []*parser.Test{ + { + Name: "Failure", + Result: parser.FAIL, + Output: []string{ + "panic: init", + "stacktrace", + }, + }, + }, + }, + }, + }, + }, + { + name: "15-empty.txt", + reportName: "15-report.xml", + report: &parser.Report{ + Packages: []parser.Package{ + { + Name: "package/empty", + Time: 1, + Tests: []*parser.Test{}, + }, + }, + }, + }, } func TestParser(t *testing.T) { diff --git a/parser/parser.go b/parser/parser.go index 2e26ddb..b854861 100644 --- a/parser/parser.go +++ b/parser/parser.go @@ -72,6 +72,9 @@ func Parse(r io.Reader, pkgName string) (*Report, error) { // the name of the package which it's build failure output is being captured var capturedPackage string + // capture any non-test output + var buffer []string + // parse lines for { l, _, err := reader.ReadLine() @@ -106,6 +109,15 @@ func Parse(r io.Reader, pkgName string) (*Report, error) { Result: FAIL, Output: packageCaptures[matches[2]], }) + } else if matches[1] == "FAIL" && len(tests) == 0 && len(buffer) > 0 { + // This package didn't have any tests, but it failed with some + // output. Create a dummy test with the output. + tests = append(tests, &Test{ + Name: "Failure", + Result: FAIL, + Output: buffer, + }) + buffer = buffer[0:0] } // all tests in this package are finished @@ -116,6 +128,7 @@ func Parse(r io.Reader, pkgName string) (*Report, error) { CoveragePct: coveragePct, }) + buffer = buffer[0:0] tests = make([]*Test, 0) coveragePct = "" cur = "" @@ -157,6 +170,9 @@ func Parse(r io.Reader, pkgName string) (*Report, error) { } else if capturedPackage != "" { // current line is build failure capture for the current built package packageCaptures[capturedPackage] = append(packageCaptures[capturedPackage], line) + } else { + // buffer anything else that we didn't recognize + buffer = append(buffer, line) } } diff --git a/tests/14-panic.txt b/tests/14-panic.txt new file mode 100644 index 0000000..405085a --- /dev/null +++ b/tests/14-panic.txt @@ -0,0 +1,6 @@ +panic: init +stacktrace +FAIL package/panic 0.003s +panic: init +stacktrace +FAIL package/panic2 0.003s diff --git a/tests/14-report.xml b/tests/14-report.xml new file mode 100644 index 0000000..d7f5295 --- /dev/null +++ b/tests/14-report.xml @@ -0,0 +1,19 @@ + + + + + + + + panic: init stacktrace + + + + + + + + panic: init stacktrace + + + diff --git a/tests/15-empty.txt b/tests/15-empty.txt new file mode 100644 index 0000000..d1c93b7 --- /dev/null +++ b/tests/15-empty.txt @@ -0,0 +1,3 @@ +testing: warning: no tests to run +PASS +ok package/empty 0.001s diff --git a/tests/15-report.xml b/tests/15-report.xml new file mode 100644 index 0000000..4ffe374 --- /dev/null +++ b/tests/15-report.xml @@ -0,0 +1,8 @@ + + + + + + + +