From 9b4f5520f7577193fd556980a30f4bee1c4e541d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=ABl=20Stemmer?= <stemmertech@gmail.com>
Date: Tue, 27 Sep 2022 21:27:34 +0100
Subject: [PATCH] Add test for reports without properties

---
 internal/gojunitreport/go-junit-report_test.go | 11 +++++++----
 testdata/039-no-properties.txt                 |  4 ++++
 testdata/039-report.xml                        |  6 ++++++
 testdata/generate-golden-reports.go            |  5 ++++-
 4 files changed, 21 insertions(+), 5 deletions(-)
 create mode 100644 testdata/039-no-properties.txt
 create mode 100644 testdata/039-report.xml

diff --git a/internal/gojunitreport/go-junit-report_test.go b/internal/gojunitreport/go-junit-report_test.go
index eaddbe7..6066757 100644
--- a/internal/gojunitreport/go-junit-report_test.go
+++ b/internal/gojunitreport/go-junit-report_test.go
@@ -21,9 +21,10 @@ const testDataDir = "../../testdata/"
 var matchTest = flag.String("match", "", "only test testdata matching this pattern")
 
 var testConfigs = map[int]Config{
-	5: {SkipXMLHeader: true},
-	6: {SkipXMLHeader: true},
-	7: {PackageName: "test/package"},
+	5:  {SkipXMLHeader: true},
+	6:  {SkipXMLHeader: true},
+	7:  {PackageName: "test/package"},
+	39: {Properties: make(map[string]string)},
 }
 
 func TestRun(t *testing.T) {
@@ -73,7 +74,9 @@ func testRun(inputFile, reportFile string, config Config, t *testing.T) {
 		config.Parser = "gojson"
 	}
 	config.Hostname = "hostname"
-	config.Properties = map[string]string{"go.version": "1.0"}
+	if config.Properties == nil {
+		config.Properties = map[string]string{"go.version": "1.0"}
+	}
 	config.TimestampFunc = func() time.Time {
 		return time.Date(2022, 1, 1, 0, 0, 0, 0, time.UTC)
 	}
diff --git a/testdata/039-no-properties.txt b/testdata/039-no-properties.txt
new file mode 100644
index 0000000..d90ba9d
--- /dev/null
+++ b/testdata/039-no-properties.txt
@@ -0,0 +1,4 @@
+=== RUN   TestPass
+--- PASS: TestPass (0.06s)
+PASS
+ok  	package/pass	0.160s
diff --git a/testdata/039-report.xml b/testdata/039-report.xml
new file mode 100644
index 0000000..f4d0378
--- /dev/null
+++ b/testdata/039-report.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuites tests="1">
+	<testsuite name="package/pass" tests="1" failures="0" errors="0" id="0" hostname="hostname" time="0.160" timestamp="2022-01-01T00:00:00Z">
+		<testcase name="TestPass" classname="package/pass" time="0.060"></testcase>
+	</testsuite>
+</testsuites>
diff --git a/testdata/generate-golden-reports.go b/testdata/generate-golden-reports.go
index 36a8424..7bec1dd 100644
--- a/testdata/generate-golden-reports.go
+++ b/testdata/generate-golden-reports.go
@@ -20,6 +20,7 @@ var configs = map[string]gojunitreport.Config{
 	"005-no-xml-header.txt": {SkipXMLHeader: true},
 	"006-mixed.txt":         {SkipXMLHeader: true},
 	"007-compiled_test.txt": {PackageName: "test/package"},
+	"039-no-properties.txt": {Properties: make(map[string]string)},
 }
 
 func main() {
@@ -104,7 +105,9 @@ func createReportFromInput(inputFile, outputFile string, write bool) error {
 	config.TimestampFunc = func() time.Time {
 		return time.Date(2022, 1, 1, 0, 0, 0, 0, time.UTC)
 	}
-	config.Properties = map[string]string{"go.version": "1.0"}
+	if config.Properties == nil {
+		config.Properties = map[string]string{"go.version": "1.0"}
+	}
 
 	_, err = config.Run(in, out)
 	return err