nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 05:00:15 -05:00
Code Issues Projects Releases Wiki Activity

Fix SetProperty and add unit test.

Browse Source
This commit is contained in:
greg-dennis 2022-08-23 13:53:51 -04:00
parent 15d215e49d
commit bf9aa098bb
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtr/gtr.go
View File

@ -78,7 +78,7 @@ func (p *Package) SetProperty(key, value string) {
// then add the specieid key-value property. // then add the specieid key-value property.
i := 0 i := 0
for _, prop := range p.Properties { for _, prop := range p.Properties {
if key == prop.Name { if key != prop.Name {
p.Properties[i] = prop p.Properties[i] = prop
i++ i++
} }

18
gtr/gtr_test.go
View File

@ -1,6 +1,10 @@
package gtr package gtr
import "testing" import (
"testing"
"github.com/google/go-cmp/cmp"
)
func TestTrimPrefixSpaces(t *testing.T) { func TestTrimPrefixSpaces(t *testing.T) {
tests := []struct { tests := []struct {
@ -24,3 +28,15 @@ func TestTrimPrefixSpaces(t *testing.T) {
} }
} }
} }
func TestSetProperty(t *testing.T) {
pkg := Package{}
pkg.SetProperty("a", "b")
pkg.SetProperty("c", "d")
pkg.SetProperty("a", "e")
want := []Property{{Name: "c", Value: "d"}, {Name: "a", Value: "e"}}
if diff := cmp.Diff(want, pkg.Properties); diff != "" {
t.Errorf("SetProperty got unexpected diff: %s", diff)
}
}