nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 13:08:07 -05:00
Code Issues Projects Releases Wiki Activity

gtr: Correctly handle packages without tests

Browse Source
This commit is contained in:
Joël Stemmer 2019-10-06 23:49:45 +01:00
parent 9167a5d41d
commit c845dfac27
2 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/gtr/builder.go
View File

@ -45,7 +45,7 @@ func (b *ReportBuilder) flush() {
// Create package in case we have tests or benchmarks that didn't get a // Create package in case we have tests or benchmarks that didn't get a
// summary. // summary.
if len(b.tests) > 0 || len(b.benchmarks) > 0 { if len(b.tests) > 0 || len(b.benchmarks) > 0 {
b.CreatePackage(b.packageName, 0, "") b.CreatePackage(b.packageName, "", 0, "")
} }
} }
@ -84,7 +84,7 @@ func (b *ReportBuilder) CreateBuildError(packageName string) {
b.buildErrors[b.newId()] = Error{Name: packageName} b.buildErrors[b.newId()] = Error{Name: packageName}
} }
func (b *ReportBuilder) CreatePackage(name string, duration time.Duration, data string) { func (b *ReportBuilder) CreatePackage(name, result string, duration time.Duration, data string) {
// Build errors are treated somewhat differently. Rather than having a // Build errors are treated somewhat differently. Rather than having a
// single package with all build errors collected so far, we only care // single package with all build errors collected so far, we only care
// about the build errors for this particular package. // about the build errors for this particular package.
@ -101,23 +101,28 @@ func (b *ReportBuilder) CreatePackage(name string, duration time.Duration, data
}) })
delete(b.buildErrors, id) delete(b.buildErrors, id)
// TODO: reset state // TODO: reset state
// TODO: buildErrors shouldn't reset/use nextId/lastId, they're more like a global cache
return return
} }
} }
// If we've collected output, but there were no tests or benchmarks then // If we've collected output, but there were no tests or benchmarks then
// there was some other error. // either there were no tests, or there was some other non-build error.
if len(b.output) > 0 && len(b.tests) == 0 && len(b.benchmarks) == 0 { if len(b.output) > 0 && len(b.tests) == 0 && len(b.benchmarks) == 0 {
b.packages = append(b.packages, Package{ pkg := Package{
Name: name, Name: name,
Duration: duration, Duration: duration,
RunError: Error{ }
if parseResult(result) == Fail {
pkg.RunError = Error{
Name: name, Name: name,
Output: b.output, Output: b.output,
}, }
}) }
b.output = nil b.packages = append(b.packages, pkg)
// TODO: reset state // TODO: reset state
b.output = nil
return return
} }

2
pkg/gtr/gtr.go
View File

@ -82,7 +82,7 @@ func FromEvents(events []Event, packageName string) Report {
report.Benchmark(ev.Name, ev.Iterations, ev.NsPerOp, ev.MBPerSec, ev.BytesPerOp, ev.AllocsPerOp) report.Benchmark(ev.Name, ev.Iterations, ev.NsPerOp, ev.MBPerSec, ev.BytesPerOp, ev.AllocsPerOp)
case "status": // ignore for now case "status": // ignore for now
case "summary": case "summary":
report.CreatePackage(ev.Name, ev.Duration, ev.Data) report.CreatePackage(ev.Name, ev.Result, ev.Duration, ev.Data)
case "coverage": case "coverage":
report.Coverage(ev.CovPct, ev.CovPackages) report.Coverage(ev.CovPct, ev.CovPackages)
case "build_output": case "build_output":