From cce73b49960a6473b4bb18efada12ce5f0208c37 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=ABl=20Stemmer?= <stemmertech@gmail.com>
Date: Thu, 11 May 2017 22:22:43 +0100
Subject: [PATCH] Change findTest to return the most recently added test

Whenever we encounter a result line in the test output, we would find
the first test with the matching name and update it. However, in some
cases it's possible for the same test name to appear multiple times in
the output. To prevent us from always updating the oldest test, the
order in which findTests searches for a matching test is reversed so
that it always returns the most recently added test.

Fixes #54.
---
 go-junit-report_test.go     | 32 ++++++++++++++++++++++++++++++++
 parser/parser.go            |  2 +-
 tests/16-repeated-names.txt |  8 ++++++++
 tests/16-report.xml         | 11 +++++++++++
 4 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 tests/16-repeated-names.txt
 create mode 100644 tests/16-report.xml

diff --git a/go-junit-report_test.go b/go-junit-report_test.go
index cb315c1..3aacf16 100644
--- a/go-junit-report_test.go
+++ b/go-junit-report_test.go
@@ -610,6 +610,38 @@ var testCases = []TestCase{
 			},
 		},
 	},
+	{
+		name:       "16-repeated-names.txt",
+		reportName: "16-report.xml",
+		report: &parser.Report{
+			Packages: []parser.Package{
+				{
+					Name: "package/repeated-names",
+					Time: 1,
+					Tests: []*parser.Test{
+						{
+							Name:   "TestRepeat",
+							Time:   0,
+							Result: parser.PASS,
+							Output: []string{},
+						},
+						{
+							Name:   "TestRepeat",
+							Time:   0,
+							Result: parser.PASS,
+							Output: []string{},
+						},
+						{
+							Name:   "TestRepeat",
+							Time:   0,
+							Result: parser.PASS,
+							Output: []string{},
+						},
+					},
+				},
+			},
+		},
+	},
 }
 
 func TestParser(t *testing.T) {
diff --git a/parser/parser.go b/parser/parser.go
index b854861..bf3a123 100644
--- a/parser/parser.go
+++ b/parser/parser.go
@@ -198,7 +198,7 @@ func parseTime(time string) int {
 }
 
 func findTest(tests []*Test, name string) *Test {
-	for i := 0; i < len(tests); i++ {
+	for i := len(tests) - 1; i >= 0; i-- {
 		if tests[i].Name == name {
 			return tests[i]
 		}
diff --git a/tests/16-repeated-names.txt b/tests/16-repeated-names.txt
new file mode 100644
index 0000000..b58f1ea
--- /dev/null
+++ b/tests/16-repeated-names.txt
@@ -0,0 +1,8 @@
+=== RUN   TestRepeat
+--- PASS: TestRepeat (0.00s)
+=== RUN   TestRepeat
+--- PASS: TestRepeat (0.00s)
+=== RUN   TestRepeat
+--- PASS: TestRepeat (0.00s)
+PASS
+ok      package/repeated-names    0.001s
diff --git a/tests/16-report.xml b/tests/16-report.xml
new file mode 100644
index 0000000..9bcc5d2
--- /dev/null
+++ b/tests/16-report.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuites>
+	<testsuite tests="3" failures="0" time="0.001" name="package/repeated-names">
+		<properties>
+			<property name="go.version" value="1.0"></property>
+		</properties>
+		<testcase classname="repeated-names" name="TestRepeat" time="0.000"></testcase>
+		<testcase classname="repeated-names" name="TestRepeat" time="0.000"></testcase>
+		<testcase classname="repeated-names" name="TestRepeat" time="0.000"></testcase>
+	</testsuite>
+</testsuites>