nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 05:00:15 -05:00
Code Issues Projects Releases Wiki Activity

junit: Remove benchmark specific code from package junit

Browse Source 
The junit package shouldn't need to know anything about benchmarks and
gtr.Benchmark will be removed in a future commit. Instead, it will be
the responsibility of the gotest parser to represent benchmarks using
gtr.Test.
This commit is contained in:
Joël Stemmer 2022-06-15 00:08:18 +01:00
parent 46e0aed494
commit dc591b8731
2 changed files with 3 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
junit/junit.go
View File

@ -160,10 +160,6 @@ func CreateFromReport(report gtr.Report, hostname string) Testsuites {
suite.AddTestcase(createTestcaseForTest(pkg.Name, test)) suite.AddTestcase(createTestcaseForTest(pkg.Name, test))
} }
for _, bm := range pkg.Benchmarks {
suite.AddTestcase(createTestcaseForBenchmark(pkg.Name, bm))
}
// JUnit doesn't have a good way of dealing with build or runtime // JUnit doesn't have a good way of dealing with build or runtime
// errors that happen before a test has started, so we create a single // errors that happen before a test has started, so we create a single
// failing test that contains the build error details. // failing test that contains the build error details.
@ -231,29 +227,6 @@ func createTestcaseForTest(pkgName string, test gtr.Test) Testcase {
return tc return tc
} }
func createTestcaseForBenchmark(pkgName string, bm gtr.Benchmark) Testcase {
tc := Testcase{
Classname: pkgName,
Name: bm.Name,
Time: formatDuration(bm.ApproximateDuration()),
}
if bm.Result == gtr.Fail {
tc.Failure = &Result{
Message: "Failed",
Data: formatOutput(bm.Output, 0),
}
} else if bm.Result == gtr.Skip {
tc.Skipped = &Result{
Message: "Skipped",
Data: formatOutput(bm.Output, 0),
}
} else if len(bm.Output) > 0 {
tc.SystemOut = &Output{Data: formatOutput(bm.Output, 0)}
}
return tc
}
// formatDuration returns the JUnit string representation of the given // formatDuration returns the JUnit string representation of the given
// duration. // duration.
func formatDuration(d time.Duration) string { func formatDuration(d time.Duration) string {

6
junit/junit_test.go
View File

@ -14,9 +14,9 @@ func TestCreateFromReport(t *testing.T) {
report := gtr.Report{ report := gtr.Report{
Packages: []gtr.Package{ Packages: []gtr.Package{
{ {
Benchmarks: []gtr.Benchmark{ Tests: []gtr.Test{
{ {
Name: "BenchmarkFail", Name: "TestFail",
Result: gtr.Fail, Result: gtr.Fail,
}, },
}, },
@ -35,7 +35,7 @@ func TestCreateFromReport(t *testing.T) {
ID: 0, ID: 0,
Testcases: []Testcase{ Testcases: []Testcase{
{ {
Name: "BenchmarkFail", Name: "TestFail",
Time: "0.000", Time: "0.000",
Failure: &Result{Message: "Failed"}, Failure: &Result{Message: "Failed"},
}, },