nhyatt/go-junit-report
1
0
Fork 0
mirror of https://github.com/jstemmer/go-junit-report.git synced 2025-04-05 21:18:08 -05:00
Code Issues Projects Releases Wiki Activity

Fix CR comments

Browse Source 
* Change regexpCapture to HasPrefix function
* Use same addition pattern of the faild build test
* Fix readme
This commit is contained in:
Eyal Posener 2017-04-01 08:36:21 +03:00
parent d10c0632c7
commit e9729a3e7e
2 changed files with 17 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -21,7 +21,7 @@ go-junit-report reads the `go test` verbose output from standard in and writes
junit compatible XML to standard out. junit compatible XML to standard out.
```bash ```bash
go test -v | go-junit-report > report.xml go test -v 2>&1 | go-junit-report > report.xml
``` ```
[travis-badge]: https://travis-ci.org/jstemmer/go-junit-report.svg [travis-badge]: https://travis-ci.org/jstemmer/go-junit-report.svg

37
parser/parser.go
View File

@ -44,7 +44,6 @@ var (
regexCoverage = regexp.MustCompile(`^coverage:\s+(\d+\.\d+)%\s+of\s+statements$`) regexCoverage = regexp.MustCompile(`^coverage:\s+(\d+\.\d+)%\s+of\s+statements$`)
regexResult = regexp.MustCompile(`^(ok|FAIL)\s+([^ ]+)\s+(?:(\d+\.\d+)s|(\[build failed]))(?:\s+coverage:\s+(\d+\.\d+)%\sof\sstatements)?$`) regexResult = regexp.MustCompile(`^(ok|FAIL)\s+([^ ]+)\s+(?:(\d+\.\d+)s|(\[build failed]))(?:\s+coverage:\s+(\d+\.\d+)%\sof\sstatements)?$`)
regexOutput = regexp.MustCompile(`( )*\t(.*)`) regexOutput = regexp.MustCompile(`( )*\t(.*)`)
regexCapture = regexp.MustCompile(`^#\s(.+)`)
) )
// Parse parses go test output from reader r and returns a report with the // Parse parses go test output from reader r and returns a report with the
@ -99,28 +98,24 @@ func Parse(r io.Reader, pkgName string) (*Report, error) {
if matches[5] != "" { if matches[5] != "" {
coveragePct = matches[5] coveragePct = matches[5]
} }
// all tests in this package are finished
pack := Package{
Name: matches[2],
CoveragePct: coveragePct,
Time: parseTime(matches[3]),
Tests: tests,
}
if matches[4] == "[build failed]" { if matches[4] == "[build failed]" {
// the build of the package failed, inject a dummy test into the package // the build of the package failed, inject a dummy test into the package
// which indicate about the failure and contain the failure description. // which indicate about the failure and contain the failure description.
pack.Tests = []*Test{ tests = append(tests, &Test{
{ Name: "build failed",
Name: "build failed", Result: FAIL,
Result: FAIL, Output: packageCaptures[matches[2]],
Output: packageCaptures[matches[2]], })
},
}
} }
report.Packages = append(report.Packages, pack) // all tests in this package are finished
report.Packages = append(report.Packages, Package{
Name: matches[2],
Time: parseTime(matches[3]),
Tests: tests,
CoveragePct: coveragePct,
})
tests = make([]*Test, 0) tests = make([]*Test, 0)
coveragePct = "" coveragePct = ""
cur = "" cur = ""
@ -156,9 +151,9 @@ func Parse(r io.Reader, pkgName string) (*Report, error) {
continue continue
} }
test.Output = append(test.Output, matches[2]) test.Output = append(test.Output, matches[2])
} else if matches := regexCapture.FindStringSubmatch(line); len(matches) == 2 { } else if strings.HasPrefix(line, "# ") {
// set the current build package // indicates a capture of build output of a package. set the current build package.
capturedPackage = matches[1] capturedPackage = line[2:]
} else if capturedPackage != "" { } else if capturedPackage != "" {
// current line is build failure capture for the current built package // current line is build failure capture for the current built package
packageCaptures[capturedPackage] = append(packageCaptures[capturedPackage], line) packageCaptures[capturedPackage] = append(packageCaptures[capturedPackage], line)