nhyatt/osslsigncode
1
0
Fork 0
mirror of https://github.com/mtrojnar/osslsigncode.git synced 2025-04-05 09:08:04 -05:00
Code Issues Projects Releases Wiki Activity

Fix resource leak, CID 1519397

Browse Source
This commit is contained in:
olszomal 2023-01-19 09:40:58 +01:00 committed by Michał Trojnara
parent d9979c4bc6
commit 4ec23dbaa5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
msi.c
View File

@ -894,7 +894,6 @@ static uint32_t stream_read(MSI_FILE *msi, MSI_ENTRY *entry, u_char *p_msi, uint
} else if (inlen != 0) { } else if (inlen != 0) {
*indata = (char *)OPENSSL_malloc(inlen); *indata = (char *)OPENSSL_malloc(inlen);
if (!msi_file_read(msi, entry, 0, *indata, inlen)) { if (!msi_file_read(msi, entry, 0, *indata, inlen)) {
OPENSSL_free(indata);
return 0; /* FAILED */ return 0; /* FAILED */
} }
} }
@ -933,6 +932,7 @@ static int stream_handle(MSI_FILE *msi, MSI_DIRENT *dirent, u_char *p_msi, uint3
inlen = stream_read(msi, child->entry, p_msi, len_msi, p_msiex, len_msiex, &indata, inlen, is_root); inlen = stream_read(msi, child->entry, p_msi, len_msi, p_msiex, len_msiex, &indata, inlen, is_root);
if (inlen == 0) { if (inlen == 0) {
printf("Failed to read stream data\n"); printf("Failed to read stream data\n");
OPENSSL_free(indata);
continue; continue;
} }
/* set the size of the user-defined data if this is a stream object */ /* set the size of the user-defined data if this is a stream object */