nhyatt/osslsigncode
1
0
Fork 0
mirror of https://github.com/mtrojnar/osslsigncode.git synced 2025-04-05 01:00:11 -05:00
Code Issues Projects Releases Wiki Activity

Fix construction of signed CAB header

Browse Source 
Commit 0f51a06 ("Separate common and format-dependent functions")
performed a substantial amount of refactoring.  Within the CFFOLDER
header construction loop in cab_add_header(), the line

   tmp = GET_UINT32_LE(indata + i);

seems to have been accidentally deleted, instead of being refactored
to become

   tmp = GET_UINT32_LE(ctx->options->indata + i);

with the result that adding a signature to a .cab file will currently
produce an invalid .cab file.

Fix by adding back in the missing line of code.

Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
This commit is contained in:
Michael Brown 2023-08-30 13:53:40 +01:00 committed by Michał Trojnara
parent 1fc2c937f2
commit 5b8376ce32
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cab.c
View File

@ -900,6 +900,7 @@ static int cab_add_header(FILE_FORMAT_CTX *ctx, BIO *hash, BIO *outdata)
*/ */
nfolders = GET_UINT16_LE(ctx->options->indata + 26); nfolders = GET_UINT16_LE(ctx->options->indata + 26);
while (nfolders) { while (nfolders) {
tmp = GET_UINT32_LE(ctx->options->indata + i);
tmp += 24; tmp += 24;
PUT_UINT32_LE(tmp, buf); PUT_UINT32_LE(tmp, buf);
BIO_write(hash, buf, 4); BIO_write(hash, buf, 4);