nhyatt/osslsigncode
1
0
Fork 0
mirror of https://github.com/mtrojnar/osslsigncode.git synced 2025-04-05 17:08:05 -05:00
Code Issues Projects Releases Wiki Activity

Fix insufficient MSI_ENTRY comparison

Browse Source
This commit is contained in:
Michał Trojnara 2023-09-04 16:10:15 +02:00
parent 5b8376ce32
commit 5d2bf2c80f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
msi.c
View File

@ -1269,9 +1269,7 @@ static int msi_dirent_new(MSI_FILE *msi, MSI_ENTRY *entry, MSI_DIRENT *parent, M
} }
/* detect cycles in previously visited entries (parents, siblings) */ /* detect cycles in previously visited entries (parents, siblings) */
if (!ret) { /* initialized (non-root entry) */ if (!ret) { /* initialized (non-root entry) */
if ((entry->leftSiblingID != NOSTREAM && tortoise->entry->leftSiblingID == entry->leftSiblingID) if (!memcmp(entry, tortoise->entry, sizeof(MSI_ENTRY))) {
|| (entry->rightSiblingID != NOSTREAM && tortoise->entry->rightSiblingID == entry->rightSiblingID)
|| (entry->childID != NOSTREAM && tortoise->entry->childID == entry->childID)) {
printf("MSI_ENTRY cycle detected at level %d\n", cnt); printf("MSI_ENTRY cycle detected at level %d\n", cnt);
OPENSSL_free(entry); OPENSSL_free(entry);
return 0; /* FAILED */ return 0; /* FAILED */