nhyatt/osslsigncode
1
0
Fork 0
mirror of https://github.com/mtrojnar/osslsigncode.git synced 2025-04-05 09:08:04 -05:00
Code Issues Projects Releases Wiki Activity

Never overwrite or unlink an existing file

Browse Source 
Fixes #9

The code uses the "x" file access mode flag introduced by the C11
standard (ISO/IEC 9899:2011).  It may be unsupported on Windows.
This commit is contained in:
Michał Trojnara 2019-07-13 15:25:41 +02:00
parent 3645ba7357
commit 891887a974
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osslsigncode.c
View File

@ -1860,9 +1860,9 @@ static int msi_extract_signature_to_file(GsfInfile *infile, char *outfile)
} }
/* Create outdata file */ /* Create outdata file */
outdata = BIO_new_file(outfile, "w+b"); outdata = BIO_new_file(outfile, "w+bx");
if (outdata == NULL) { if (outdata == NULL) {
printf("Unable to open %s\n\n", outfile); printf("Unable to create %s\n\n", outfile);
ret = 1; ret = 1;
goto out; goto out;
} }
@ -2792,9 +2792,9 @@ int main(int argc, char **argv) {
sig = msi_extract_signature_to_pkcs7(ole); sig = msi_extract_signature_to_pkcs7(ole);
if (!sig) if (!sig)
DO_EXIT_0("Unable to extract existing signature\n"); DO_EXIT_0("Unable to extract existing signature\n");
outdata = BIO_new_file(outfile, "w+b"); outdata = BIO_new_file(outfile, "w+bx");
if (outdata == NULL) if (outdata == NULL)
DO_EXIT_1("Unable to open %s\n", outfile); DO_EXIT_1("Unable to create %s\n", outfile);
ret = !PEM_write_bio_PKCS7(outdata, sig); ret = !PEM_write_bio_PKCS7(outdata, sig);
BIO_free_all(outdata); BIO_free_all(outdata);
} else { } else {
@ -2913,7 +2913,7 @@ int main(int argc, char **argv) {
if (type == FILE_TYPE_CAB || type == FILE_TYPE_PE) { if (type == FILE_TYPE_CAB || type == FILE_TYPE_PE) {
if (cmd != CMD_VERIFY) { if (cmd != CMD_VERIFY) {
/* Create outdata file */ /* Create outdata file */
outdata = BIO_new_file(outfile, "w+b"); outdata = BIO_new_file(outfile, "w+bx");
if (outdata == NULL) if (outdata == NULL)
DO_EXIT_1("Failed to create file: %s\n", outfile); DO_EXIT_1("Failed to create file: %s\n", outfile);
BIO_push(hash, outdata); BIO_push(hash, outdata);
@ -3387,7 +3387,7 @@ err_cleanup:
EVP_PKEY_free(pkey); EVP_PKEY_free(pkey);
if (hash) if (hash)
BIO_free_all(hash); BIO_free_all(hash);
if (outfile) if (outdata)
unlink(outfile); unlink(outfile);
fprintf(stderr, "\nFailed\n"); fprintf(stderr, "\nFailed\n");
cleanup_lib_state(); cleanup_lib_state();