nhyatt/osslsigncode
1
0
Fork 0
mirror of https://github.com/mtrojnar/osslsigncode.git synced 2025-04-04 17:00:11 -05:00
Code Issues Projects Releases Wiki Activity

Fix unchecked return value, CID 1519390

Browse Source
This commit is contained in:
olszomal 2023-01-12 12:58:02 +01:00 committed by Michał Trojnara
parent d59601f2b9
commit f67ca8aac5
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osslsigncode.c
View File

@ -1572,7 +1572,7 @@ static u_char *pe_calc_page_hash(char *indata, uint32_t header_size,
if (!EVP_DigestInit(mdctx, md)) { if (!EVP_DigestInit(mdctx, md)) {
EVP_MD_CTX_free(mdctx); EVP_MD_CTX_free(mdctx);
printf("Unable to set up the digest context\n"); printf("Unable to set up the digest context\n");
return NULL; /* FAILED */ return NULL; /* FAILED */
} }
nsections = GET_UINT16_LE(indata + header_size + 6); nsections = GET_UINT16_LE(indata + header_size + 6);
pagesize = GET_UINT32_LE(indata + header_size + 56); pagesize = GET_UINT32_LE(indata + header_size + 56);
@ -1598,7 +1598,13 @@ static u_char *pe_calc_page_hash(char *indata, uint32_t header_size,
ro = GET_UINT32_LE(sections + 20); ro = GET_UINT32_LE(sections + 20);
for (l=0; l < rs; l+=pagesize, pi++) { for (l=0; l < rs; l+=pagesize, pi++) {
PUT_UINT32_LE(ro + l, res + pi*pphlen); PUT_UINT32_LE(ro + l, res + pi*pphlen);
EVP_DigestInit(mdctx, md); if (!EVP_DigestInit(mdctx, md)) {
EVP_MD_CTX_free(mdctx);
OPENSSL_free(res);
OPENSSL_free(zeroes);
printf("Unable to set up the digest context\n");
return NULL; /* FAILED */
}
if (rs - l < pagesize) { if (rs - l < pagesize) {
EVP_DigestUpdate(mdctx, indata + ro + l, rs - l); EVP_DigestUpdate(mdctx, indata + ro + l, rs - l);
EVP_DigestUpdate(mdctx, zeroes, pagesize - (rs - l)); EVP_DigestUpdate(mdctx, zeroes, pagesize - (rs - l));