putty-source/windows/winseat.h

/*
 * Small implementation of Seat and LogPolicy shared between window.c
 * and windlg.c.
 */

typedef struct WinGuiSeat WinGuiSeat;

struct WinGuiSeat {
    HWND term_hwnd;
    Seat seat;
    LogPolicy logpolicy;
};

extern const LogPolicyVtable win_gui_logpolicy_vt; /* in windlg.c */
GUI PuTTY: stop using the global 'hwnd'. This was the difficult part of cleaning up that global variable. The main Windows PuTTY GUI is split between source files, so that _does_ actually need to refer to the main window from multiple places. But all the places where windlg.c needed to use 'hwnd' are seat methods, so they were already receiving a Seat pointer as a parameter. In other words, the methods of the Windows GUI Seat were already split between source files. So it seems only fair that they should be able to share knowledge of the seat's data as well. Hence, I've created a small 'WinGuiSeat' structure which both window.c and windlg.c can see the layout of, and put the main terminal window handle in there. Then the seat methods implemented in windlg.c, like win_seat_verify_ssh_host_key, can use container_of to turn the Seat pointer parameter back into the address of that structure, just as the methods in window.c can do (even though they currently don't need to). (Who knows: now that it _exists_, perhaps that structure can be gradually expanded in future to turn it into a proper encapsulation of all the Windows frontend's state, like we should have had all along...) I've also moved the Windows GUI LogPolicy implementation into the same object (i.e. WinGuiSeat implements both traits at once). That allows win_gui_logging_error to recover the same WinGuiSeat from its input LogPolicy pointer, which means it can get from there to the Seat facet of the same object, so that I don't need the extern variable 'win_seat' any more either. 2020-02-02 10:00:43 +00:00			`/*`
			`* Small implementation of Seat and LogPolicy shared between window.c`
			`* and windlg.c.`
			`*/`

			`typedef struct WinGuiSeat WinGuiSeat;`

			`struct WinGuiSeat {`
			`HWND term_hwnd;`
			`Seat seat;`
			`LogPolicy logpolicy;`
			`};`

			`extern const LogPolicyVtable win_gui_logpolicy_vt; /* in windlg.c */`