nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-25 09:12:24 +00:00
Code Issues Projects Releases Wiki Activity

Fix potential buffer overrun in new saved-session menu

Browse Source 
[originally from svn r267]
This commit is contained in:
Simon Tatham 1999-11-01 17:18:08 +00:00
parent 6693daa636
commit 0e3f5802b3
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
window.c
View File

@ -627,6 +627,7 @@ static int WINAPI WndProc (HWND hwnd, UINT message,
{ {
char b[2048]; char b[2048];
char c[30], *cl; char c[30], *cl;
int freecl = FALSE;
STARTUPINFO si; STARTUPINFO si;
PROCESS_INFORMATION pi; PROCESS_INFORMATION pi;
HANDLE filemap = NULL; HANDLE filemap = NULL;
@ -660,9 +661,12 @@ static int WINAPI WndProc (HWND hwnd, UINT message,
sprintf(c, "putty &%08x", filemap); sprintf(c, "putty &%08x", filemap);
cl = c; cl = c;
} else if (wParam == IDM_SAVEDSESS) { } else if (wParam == IDM_SAVEDSESS) {
sprintf(c, "putty @%s", char *session = sessions[(lParam - IDM_SAVED_MIN) / 16];
sessions[(lParam - IDM_SAVED_MIN) / 16]); cl = malloc(16 + strlen(session)); /* 8, but play safe */
cl = c; if (!cl)
cl = NULL; /* not a very important failure mode */
sprintf(cl, "putty @%s", session);
freecl = TRUE;
} else } else
cl = NULL; cl = NULL;
@ -679,6 +683,8 @@ static int WINAPI WndProc (HWND hwnd, UINT message,
if (filemap) if (filemap)
CloseHandle(filemap); CloseHandle(filemap);
if (freecl)
free(cl);
} }
break; break;
case IDM_RECONF: case IDM_RECONF: