nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-02-09 16:36:34 +00:00
Code Issues Projects Releases Wiki Activity

Replace an ad-hoc buffer-clearing loop with smemclr.

Browse Source 
Thanks to @ch3root on Twitter for spotting it, and thanks to Chris
Emerson for bothering to let me know. I must have missed this when I
code-reviewed the ECC contribution.
This commit is contained in:
Simon Tatham 2016-01-25 19:24:41 +00:00
parent 51465fac73
commit 0f1cab3182
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sshecc.c
View File

@ -2761,10 +2761,7 @@ void *ssh_ecdhkex_newkey(const struct ssh_kex *kex)
bytes[31] &= 127; bytes[31] &= 127;
bytes[31] |= 64; bytes[31] |= 64;
key->privateKey = bignum_from_bytes(bytes, sizeof(bytes)); key->privateKey = bignum_from_bytes(bytes, sizeof(bytes));
for (i = 0; i < sizeof(bytes); ++i) smemclr(bytes, sizeof(bytes));
{
((volatile char*)bytes)[i] = 0;
}
if (!key->privateKey) { if (!key->privateKey) {
sfree(key); sfree(key);
return NULL; return NULL;