nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-09 17:38:00 +00:00
Code Issues Projects Releases Wiki Activity

Close agent named-pipe handles when queries complete.

Browse Source 
I was cleaning up the 'struct handle', but not the underlying HANDLE.
As a result, any PuTTY process that makes a request to Pageant keeps
the named pipe connection open until the end of the process's
lifetime.

(cherry picked from commit 6e69223dc2)
This commit is contained in:
Simon Tatham 2021-05-13 18:22:05 +01:00
parent 6976bf6082
commit 11b89407f5
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
windows/winpgntc.c
View File

@ -169,6 +169,7 @@ bool agent_exists(void)
struct agent_pending_query { struct agent_pending_query {
struct handle *handle; struct handle *handle;
HANDLE os_handle;
strbuf *response; strbuf *response;
void (*callback)(void *, void *, int); void (*callback)(void *, void *, int);
void *callback_ctx; void *callback_ctx;
@ -266,6 +267,7 @@ static agent_pending_query *named_pipe_agent_query(
pq = snew(agent_pending_query); pq = snew(agent_pending_query);
pq->handle = handle_input_new(pipehandle, named_pipe_agent_gotdata, pq, 0); pq->handle = handle_input_new(pipehandle, named_pipe_agent_gotdata, pq, 0);
pq->os_handle = pipehandle;
pipehandle = INVALID_HANDLE_VALUE; /* prevent it being closed below */ pipehandle = INVALID_HANDLE_VALUE; /* prevent it being closed below */
pq->response = strbuf_new_nm(); pq->response = strbuf_new_nm();
pq->callback = callback; pq->callback = callback;
@ -290,6 +292,7 @@ static agent_pending_query *named_pipe_agent_query(
void agent_cancel_query(agent_pending_query *pq) void agent_cancel_query(agent_pending_query *pq)
{ {
handle_free(pq->handle); handle_free(pq->handle);
CloseHandle(pq->os_handle);
if (pq->response) if (pq->response)
strbuf_free(pq->response); strbuf_free(pq->response);
sfree(pq); sfree(pq);