From 1620aef7c6ca54754111469a47645b26e049387e Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sat, 2 Apr 2016 08:00:25 +0100 Subject: [PATCH] MSI installer: offer to display the README file after install. This is a thing that the Inno Setup installer did, and that I didn't get round to replicating when I rushed out the initial MSI in a hurry. I've checked that this doesn't prevent unattended installation by administrators: running 'msiexec /q /i putty-whatever.msi' as administrator still installs silently after this change, without popping up the README unexpectedly on anyone's desktop as a side effect. (I _think_ - but I'm still a long way from an MSI expert - that that's because /q turns off the whole UI part of the MSI system, and the loading of README is actually triggered by the transition away from the final UI dialog box, which we now never visit in the first place.) --- Buildscr | 2 +- windows/installer.wxs | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Buildscr b/Buildscr index 6e2bbc3b..e530ad12 100644 --- a/Buildscr +++ b/Buildscr @@ -171,7 +171,7 @@ delegate windows in putty/doc with htmlhelp do/win hhc putty.hhp & type putty.chm >nul # Build the WiX MSI installer. - in putty/windows with wix do/win candle -dWinver="$(Winver)" -dPuttytextver="$(Puttytextver)" installer.wxs && light -ext WixUIExtension -sval installer.wixobj + in putty/windows with wix do/win candle -dWinver="$(Winver)" -dPuttytextver="$(Puttytextver)" installer.wxs && light -ext WixUIExtension -ext WixUtilExtension -sval installer.wixobj # Build the old Inno Setup installer. in putty/windows with innosetup do/win iscc putty.iss diff --git a/windows/installer.wxs b/windows/installer.wxs index d4aa6c35..22ea6e4a 100644 --- a/windows/installer.wxs +++ b/windows/installer.wxs @@ -420,6 +420,9 @@ 1 1 + WIXUI_EXITDIALOGOPTIONALCHECKBOX = 1 and NOT Installed + + + + + +