From 18ab91a199b585a7f53612fd068b93e607e2b2f0 Mon Sep 17 00:00:00 2001
From: Simon Tatham <anakin@pobox.com>
Date: Fri, 18 May 2018 11:49:00 +0100
Subject: [PATCH] ssh1_rdpkt: remove a spurious crReturn.

Returning from the coroutine every time we finish putting together a
packet is wrong, because it means that any further data in the
incoming queue won't get processed until something triggers another
call to the coroutine. In ssh2_rdpkt I got this right - the only
crReturn that _isn't_ due to running out of data is the special one
immediately after a NEWKEYS - but I forgot to fix it the same way in
ssh1_rdpkt.
---
 ssh.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ssh.c b/ssh.c
index 5ee6b96c..b40a17c8 100644
--- a/ssh.c
+++ b/ssh.c
@@ -1602,7 +1602,6 @@ static void ssh1_rdpkt(Ssh ssh)
 
         pq_push(&ssh->pq_full, st->pktin);
         queue_idempotent_callback(&ssh->pq_full_consumer);
-        crReturnV;
     }
     crFinishV;
 }