From 1986ee2d9ce1f29bbb9a6d0d41ef07d185213eac Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sat, 13 Oct 2018 17:16:07 +0100 Subject: [PATCH] Add missing pq_pop when handling SSH_MSG_DISCONNECT. Somehow I managed to leave that line out in both SSH-1 and SSH-2's functions for handling DISCONNECT, IGNORE and DEBUG, and in both cases, only for DISCONNECT. Oops. --- ssh1login.c | 1 + ssh2transport.c | 1 + 2 files changed, 2 insertions(+) diff --git a/ssh1login.c b/ssh1login.c index 08282d5b..8b6f1d7b 100644 --- a/ssh1login.c +++ b/ssh1login.c @@ -132,6 +132,7 @@ int ssh1_common_filter_queue(PacketProtocolLayer *ppl) ssh_remote_error(ppl->ssh, "Server sent disconnect message:\n\"%.*s\"", PTRLEN_PRINTF(msg)); + pq_pop(ppl->in_pq); return TRUE; /* indicate that we've been freed */ case SSH1_MSG_DEBUG: diff --git a/ssh2transport.c b/ssh2transport.c index 343d6787..7f316ec0 100644 --- a/ssh2transport.c +++ b/ssh2transport.c @@ -530,6 +530,7 @@ int ssh2_common_filter_queue(PacketProtocolLayer *ppl) ((reason > 0 && reason < lenof(ssh2_disconnect_reasons)) ? ssh2_disconnect_reasons[reason] : "unknown"), PTRLEN_PRINTF(msg)); + pq_pop(ppl->in_pq); return TRUE; /* indicate that we've been freed */ case SSH2_MSG_DEBUG: