From 1f6fa876e3be4eb9753319bee5d17624f8400452 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sat, 29 Jan 2022 17:58:33 +0000 Subject: [PATCH] do_bidi: remove a pointless assert. When the textlen parameter became a size_t, it became unsigned, so it stopped being useful to assert() its non-negativity. Spotted by Coverity. Harmless, but ordinary compilers have been known to emit annoying warnings about that kind of thing too, so it's worth fixing just to avoid noise. --- terminal/bidi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/terminal/bidi.c b/terminal/bidi.c index c8085ca4..a56570fd 100644 --- a/terminal/bidi.c +++ b/terminal/bidi.c @@ -3602,7 +3602,6 @@ void do_bidi(BidiContext *ctx, bidi_char *text, size_t textlen) #ifdef REMOVE_FORMATTING_CHARACTERS abort(); /* can't use the standard algorithm in a live terminal */ #else - assert(textlen >= 0); do_bidi_new(ctx, text, textlen); #endif }