nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-26 01:32:25 +00:00
Code Issues Projects Releases Wiki Activity

Fix a memory leak in ssh1_channel_close_local.

Browse Source 
Leak Sanitiser was kind enough to point this out to me during testing
of the port forwarding rework: chan_log_close_msg() returns a
dynamically allocated char *, which the caller is supposed to free.
This commit is contained in:
Simon Tatham 2020-01-27 19:40:58 +00:00
parent 2160205aee
commit 22350d7668
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ssh1connection.c
View File

@ -520,10 +520,12 @@ static void ssh1_channel_close_local(struct ssh1_channel *c,
{ {
struct ssh1_connection_state *s = c->connlayer; struct ssh1_connection_state *s = c->connlayer;
PacketProtocolLayer *ppl = &s->ppl; /* for ppl_logevent */ PacketProtocolLayer *ppl = &s->ppl; /* for ppl_logevent */
const char *msg = chan_log_close_msg(c->chan); char *msg = chan_log_close_msg(c->chan);
if (msg != NULL) if (msg != NULL) {
ppl_logevent("%s%s%s", msg, reason ? " " : "", reason ? reason : ""); ppl_logevent("%s%s%s", msg, reason ? " " : "", reason ? reason : "");
sfree(msg);
}
chan_free(c->chan); chan_free(c->chan);
c->chan = zombiechan_new(); c->chan = zombiechan_new();