1
0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-04-18 03:28:07 -05:00

sk_nonamelookup() should ensure the sockaddr it returns has `error'

set to NULL. Otherwise it'll be random uninitialised goop. Not good.

[originally from svn r2416]
This commit is contained in:
Simon Tatham 2003-01-02 10:07:50 +00:00
parent 327b9b7f1a
commit 2435c54597
2 changed files with 2 additions and 0 deletions

View File

@ -203,6 +203,7 @@ SockAddr sk_namelookup(char *host, char **canonicalname)
SockAddr sk_nonamelookup(char *host) SockAddr sk_nonamelookup(char *host)
{ {
SockAddr ret = smalloc(sizeof(struct SockAddr_tag)); SockAddr ret = smalloc(sizeof(struct SockAddr_tag));
ret->error = NULL;
ret->family = AF_UNSPEC; ret->family = AF_UNSPEC;
strncpy(ret->hostname, host, lenof(ret->hostname)); strncpy(ret->hostname, host, lenof(ret->hostname));
ret->hostname[lenof(ret->hostname)-1] = '\0'; ret->hostname[lenof(ret->hostname)-1] = '\0';

View File

@ -365,6 +365,7 @@ SockAddr sk_namelookup(char *host, char **canonicalname)
SockAddr sk_nonamelookup(char *host) SockAddr sk_nonamelookup(char *host)
{ {
SockAddr ret = smalloc(sizeof(struct SockAddr_tag)); SockAddr ret = smalloc(sizeof(struct SockAddr_tag));
ret->error = NULL;
ret->family = AF_UNSPEC; ret->family = AF_UNSPEC;
strncpy(ret->hostname, host, lenof(ret->hostname)); strncpy(ret->hostname, host, lenof(ret->hostname));
ret->hostname[lenof(ret->hostname)-1] = '\0'; ret->hostname[lenof(ret->hostname)-1] = '\0';