From 25c45bf0438ff596b588ccbd9a508b89f7fb9760 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Tue, 18 Dec 2012 09:02:38 +0000 Subject: [PATCH] Use O_NOCTTY (if available) when opening /dev/ptmx, just in case any OS doesn't automatically assume it. (It would seem faintly weird to me - surely opening the master end of a given pty is a fairly good indication that you're _not_ a process running inside it which wants to have it available as /dev/tty! But you never know...) [originally from svn r9727] --- unix/uxpty.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/unix/uxpty.c b/unix/uxpty.c index 36a05fcc..99c1221a 100644 --- a/unix/uxpty.c +++ b/unix/uxpty.c @@ -335,7 +335,14 @@ static void pty_open_master(Pty pty) chown(pty->name, getuid(), gp ? gp->gr_gid : -1); chmod(pty->name, 0600); #else - pty->master_fd = open("/dev/ptmx", O_RDWR); + + const int flags = O_RDWR +#ifdef O_NOCTTY + | O_NOCTTY +#endif + ; + + pty->master_fd = open("/dev/ptmx", flags); if (pty->master_fd < 0) { perror("/dev/ptmx: open");