diff --git a/CHECKLST.txt b/CHECKLST.txt index 73b8c45c..a67395de 100644 --- a/CHECKLST.txt +++ b/CHECKLST.txt @@ -37,14 +37,26 @@ Things to do during the branch-stabilisation period: word XXX-REVIEW-BEFORE-RELEASE. (Any such comments should state clearly what needs to be done.) - - Do some testing of the Windows version with Minefield (you can - build a Minefield version using 'bob . XFLAGS=-DMINEFIELD'), and of - the Unix version with valgrind and/or Address Sanitiser. In - particular, any headline features for the release should get a - workout with memory checking enabled! + - Test the Unix build with Address Sanitiser. In particular, any + headline features for the release should get a workout with memory + checking enabled! - - Test the CMake build scripts with the oldest CMake they claim to - support, on both Unix and Windows. + - Test the Windows build with Address Sanitiser too (as of VS 2022). + + In the course of that, give a recent Windows pterm a try, to + make sure that still works. + + - Test building and running on old platforms: + + build on Debian stretch (containing CMake 3.7, the earliest + CMake we claim support for) + + build with all three major versions of GTK + + build the old-Windows binaries and test-run them on Win95 (PuTTY + proper even without WinSock2) + + - Check Coverity is happy. + + - Check the side-channel tester is happy. + + - Check all the non-SSH network backends still basically work. Making a release candidate build -------------------------------- diff --git a/unix/window.c b/unix/window.c index de75a1c2..64efb968 100644 --- a/unix/window.c +++ b/unix/window.c @@ -2564,8 +2564,10 @@ static void request_resize_internal(GtkFrontend *inst, bool from_terminal, GdkWindowState state = gdk_window_get_state(gdkwin); if (state & (GDK_WINDOW_STATE_MAXIMIZED | GDK_WINDOW_STATE_FULLSCREEN | -#if GTK_CHECK_VERSION(3,0,0) +#if GTK_CHECK_VERSION(3,10,0) GDK_WINDOW_STATE_TILED | +#endif +#if GTK_CHECK_VERSION(3,22,23) GDK_WINDOW_STATE_TOP_TILED | GDK_WINDOW_STATE_RIGHT_TILED | GDK_WINDOW_STATE_BOTTOM_TILED |