nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-03-16 12:03:03 -05:00
Code Issues Projects Releases Wiki Activity

I believe that verify_ssh_host_key() should now be passed a real front-end

Browse Source 
handle, which removes one of its many flaws.

[originally from svn r3181]
This commit is contained in:
Ben Harris 2003-05-10 12:27:38 +00:00
parent 4f7241090f
commit 25ff4e0ed9
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
mac/mac.c
View File

@ -1,4 +1,4 @@
/* $Id: mac.c,v 1.58 2003/05/10 11:40:18 ben Exp $ */ /* $Id: mac.c,v 1.59 2003/05/10 12:27:38 ben Exp $ */
/* /*
* Copyright (c) 1999, 2003 Ben Harris * Copyright (c) 1999, 2003 Ben Harris
* All rights reserved. * All rights reserved.
@ -672,18 +672,11 @@ int agent_query(void *in, int inlen, void **out, int *outlen,
/* Temporary null routines for testing. */ /* Temporary null routines for testing. */
/*
* FIXME: verify_ssh_host_key() should be passed a frontend handle,
* but backends have to have a terminal handle instead, because they
* pass it to from_backend(), so we accept a terminal handle here as
* well, and hope no-one tries to call us with sensible arguments.
*/
void verify_ssh_host_key(void *frontend, char *host, int port, char *keytype, void verify_ssh_host_key(void *frontend, char *host, int port, char *keytype,
char *keystr, char *fingerprint) char *keystr, char *fingerprint)
{ {
Str255 stuff; Str255 stuff;
Terminal *term = frontend; Session *s = frontend;
Session *s = term->frontend;
/* /*
* This function is horribly wrong. For one thing, the alert * This function is horribly wrong. For one thing, the alert
@ -692,9 +685,9 @@ void verify_ssh_host_key(void *frontend, char *host, int port, char *keytype,
* should use the Notification Manager to wake up the user. In * should use the Notification Manager to wake up the user. In
* any case, we shouldn't hold up processing of other connections' * any case, we shouldn't hold up processing of other connections'
* data just because this one's waiting for the user. It should * data just because this one's waiting for the user. It should
* also handle a host key cache, of course, and see the note above * also handle a host key cache, of course, and see the note below
* about the "frontend" argument and the one below about closing * about closing the connection. All in all, a bit of a mess
* the connection. All in all, a bit of a mess really. * really.
*/ */
stuff[0] = sprintf((char *)(&stuff[1]), stuff[0] = sprintf((char *)(&stuff[1]),