nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 09:58:01 +00:00
Code Issues Projects Releases Wiki Activity

Adjust comments around split_into_argv() to clarify that it's not

Browse Source 
*Windows's* command-line splitting rules we're mimicking here; it's
VC7's, and they're not the same as VC10's.

[originally from svn r9748]
This commit is contained in:
Simon Tatham 2013-01-19 17:17:44 +00:00
parent 896f9f2256
commit 2ebdd3799d
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
windows/winutils.c
View File

@ -170,12 +170,12 @@ char *GetDlgItemText_alloc(HWND hwnd, int id)
} }
/* /*
* Split a complete command line into argc/argv, attempting to do * Split a complete command line into argc/argv, attempting to do it
* it exactly the same way Windows itself would do it (so that * exactly the same way the Visual Studio C library would do it (so
* console utilities, which receive argc and argv from Windows, * that our console utilities, which receive argc and argv already
* will have their command lines processed in the same way as GUI * broken apart by the C library, will have their command lines
* utilities which get a whole command line and must break it * processed in the same way as the GUI utilities which get a whole
* themselves). * command line and must call this function).
* *
* Does not modify the input command line. * Does not modify the input command line.
* *
@ -196,7 +196,17 @@ void split_into_argv(char *cmdline, int *argc, char ***argv,
int outputargc; int outputargc;
/* /*
* At first glance the rules appeared to be: * These argument-breaking rules apply to Visual Studio 7, which
* is currently the compiler expected to be used for PuTTY. Visual
* Studio 10 has different rules, lacking the curious mod 3
* behaviour of consecutive quotes described below; I presume they
* fixed a bug. As and when we migrate to a newer compiler, we'll
* have to adjust this to match; however, for the moment we
* faithfully imitate in our GUI utilities what our CLI utilities
* can't be prevented from doing.
*
* When I investigated this, at first glance the rules appeared to
* be:
* *
* - Single quotes are not special characters. * - Single quotes are not special characters.
* *