nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-04-21 21:15:03 -05:00
Code Issues Projects Releases Wiki Activity

Fix duplicate packets in CBC mode.

Browse Source 
Yesterday's reinstatement of ssh_free_pktout revealed - via valgrind
spotting the use-after-free - that the code that prefixed sensible
packets with IV-muddling SSH_MSG_IGNOREs was actually sending a second
copy of the sensible packet in place of the IGNORE, due to a typo.
This commit is contained in:
Simon Tatham 2018-07-10 21:04:32 +01:00
parent d4abff521a
commit 445fa12da7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ssh.c
View File

@ -1216,7 +1216,7 @@ static void ssh_pkt_write(Ssh ssh, PktOut *pkt)
*/ */
PktOut *ipkt = ssh_bpp_new_pktout(ssh->bpp, SSH2_MSG_IGNORE); PktOut *ipkt = ssh_bpp_new_pktout(ssh->bpp, SSH2_MSG_IGNORE);
put_stringz(ipkt, ""); put_stringz(ipkt, "");
ssh_bpp_format_packet(ssh->bpp, pkt); ssh_bpp_format_packet(ssh->bpp, ipkt);
} }
ssh_bpp_format_packet(ssh->bpp, pkt); ssh_bpp_format_packet(ssh->bpp, pkt);