nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-06-30 19:12:48 -05:00
Code Issues Projects Releases Wiki Activity

Remove TermWin's is_utf8 method.

Browse Source 
All implementations of it work by checking the line_codepage field in
the ucsdata structure that the terminal itself already has a pointer
to. Therefore, it's a totally unnecessary query function: the terminal
can check the same thing directly by inspecting that structure!

(In fact, it already _does_ do that, for the purpose of actually
deciding how to decode terminal output data. It only uses this query
function at all for the auxiliary purpose of inventing useful tty
modes to pass to the backend.)
This commit is contained in:
Simon Tatham
2021-02-07 19:59:20 +00:00
parent b63a66cd2c
commit 45b03419fd
5 changed files with 2 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
unix/gtkwin.c
View File

@ -348,7 +348,7 @@ static int gtk_seat_get_userpass_input(Seat *seat, prompts_t *p,
static bool gtk_seat_is_utf8(Seat *seat)
{
GtkFrontend *inst = container_of(seat, GtkFrontend, seat);
return win_is_utf8(&inst->termwin);
return inst->ucsdata.line_codepage == CS_UTF8;
}
static bool gtk_seat_get_window_pixel_size(Seat *seat, int *w, int *h)
@ -4251,12 +4251,6 @@ static bool gtk_seat_get_windowid(Seat *seat, long *id)
}
#endif
static bool gtkwin_is_utf8(TermWin *tw)
{
GtkFrontend *inst = container_of(tw, GtkFrontend, termwin);
return inst->ucsdata.line_codepage == CS_UTF8;
}
char *setup_fonts_ucs(GtkFrontend *inst)
{
bool shadowbold = conf_get_bool(inst->conf, CONF_shadowbold);
@ -5197,7 +5191,6 @@ static const TermWinVtable gtk_termwin_vt = {
.get_pos = gtkwin_get_pos,
.get_pixels = gtkwin_get_pixels,
.get_title = gtkwin_get_title,
.is_utf8 = gtkwin_is_utf8,
};
void new_session_window(Conf *conf, const char *geometry_string)