From 46cf862c31a0a5b3b6332c0ed713b11f447afb87 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Mon, 27 Nov 2017 20:22:10 +0000 Subject: [PATCH] Knock off another refactoring from the OS X to-do list. Stopping dialog boxes from being modal is now done; post_main() is defunct; nothing left in gtkwin.c does an inappropriate whole-process termination in response to a window-level error or closure condition. (There is still modalfatalbox(), but that's not an _inappropriate_ process termination.) --- unix/gtkapp.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/unix/gtkapp.c b/unix/gtkapp.c index 6a48da35..d1861b1e 100644 --- a/unix/gtkapp.c +++ b/unix/gtkapp.c @@ -62,18 +62,6 @@ behaviour inherited from ordinary Unix PuTTY. Should arrange to have a mode in which you have to take an explicit Copy action, and then arrange that the Edit menu includes one of those. -Dialog boxes shouldn't be modal. I think this is a good policy change -in general, and the required infrastructure changes will benefit the -Windows front end too, but for a multi-session process it's even more -critical - you need to be able to type into one session window while -setting up the configuration for launching another. So everywhere we -currently run a sub-instance of gtk_main, or call any API function -that implicitly does that (like gtk_dialog_run), we should switch to -putting up the dialog box and going back to our ordinary main loop, -and whatever we were going to do after the dialog closed we should -remember to do it when that happens later on. Also then we can remove -the post_main() horror from gtkcomm.c. - The application menu bar is very minimal at the moment. Should include all the usual stuff from the Ctrl-right-click menu - saved sessions, mid-session special commands, Duplicate Session, Change Settings,