nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-04-03 04:00:12 -05:00
Code Issues Projects Releases Wiki Activity

Merge kex-hybrid memory leak fix from 'pre-0.83'

Browse Source
This commit is contained in:
Simon Tatham 2025-02-01 11:11:40 +00:00
commit 476ecf427a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crypto/kex-hybrid.c
View File

@ -146,6 +146,7 @@ static bool hybrid_client_getkey(ecdh_key *ek, ptrlen remoteKey, BinarySink *bs)
if (!ecdh_key_getkey(s->classical, classical_data, if (!ecdh_key_getkey(s->classical, classical_data,
BinarySink_UPCAST(classical_key))) { BinarySink_UPCAST(classical_key))) {
ssh_hash_free(h); ssh_hash_free(h);
strbuf_free(classical_key);
return false; /* classical DH key didn't validate */ return false; /* classical DH key didn't validate */
} }
s->alg->reformat(ptrlen_from_strbuf(classical_key), BinarySink_UPCAST(h)); s->alg->reformat(ptrlen_from_strbuf(classical_key), BinarySink_UPCAST(h));
@ -238,6 +239,7 @@ static bool hybrid_server_getkey(ecdh_key *ek, ptrlen remoteKey, BinarySink *bs)
if (!ecdh_key_getkey(s->classical, classical_data, if (!ecdh_key_getkey(s->classical, classical_data,
BinarySink_UPCAST(classical_key))) { BinarySink_UPCAST(classical_key))) {
ssh_hash_free(h); ssh_hash_free(h);
strbuf_free(classical_key);
return false; /* classical DH key didn't validate */ return false; /* classical DH key didn't validate */
} }
s->alg->reformat(ptrlen_from_strbuf(classical_key), BinarySink_UPCAST(h)); s->alg->reformat(ptrlen_from_strbuf(classical_key), BinarySink_UPCAST(h));