From 4948b79114aca6150800c7539395fdc7c391efdc Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 3 May 2020 11:17:55 +0100 Subject: [PATCH] test/numbertheory.py: fix comment wording. The class for general rth-root finding started off as a cube-root finder before I generalised it, and in one part of the top-level explanatory comment, I still referred to a subgroup having index 3 rather than index r. Also, in a later paragraph, I seem to have said 'index' several times where I meant the concept of 'rank' I defined in the previous paragraph. --- test/numbertheory.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/numbertheory.py b/test/numbertheory.py index 79d88fa8..58f601eb 100644 --- a/test/numbertheory.py +++ b/test/numbertheory.py @@ -47,7 +47,7 @@ class CyclicGroupRootFinder(object): # # We write |G| = r^k u, with u coprime to r. This gives us a # nested sequence of subgroups G = G_0 > G_1 > ... > G_k, each - # with index 3 in its predecessor. G_0 is the whole group, and the + # with index r in its predecessor. G_0 is the whole group, and the # innermost G_k has order u. # # Within G_k, you can take an rth root by raising an element to @@ -61,9 +61,9 @@ class CyclicGroupRootFinder(object): # take rth roots of, as above. # # In between, you can follow an inductive process, as long as you - # know one element z of index 0. Suppose we're trying to take the - # rth root of some g with index i. Repeatedly multiply g by - # z^{r^i} until its index increases; then take the root of that + # know one element z of rank 0. Suppose we're trying to take the + # rth root of some g with rank i. Repeatedly multiply g by z^{r^i} + # until its rank increases; then take the root of that # (recursively), and divide off z^{r^{i-1}} once you're done. def __init__(self, r, order):