nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-03-28 09:17:07 -05:00
Code Issues Projects Releases Wiki Activity

Make the -legacy-foo options not SAVEABLE.

Browse Source 
They weren't being enacted if you ran psftp without a hostname and
later issued an 'open' command, because in that code path,
cmdline_run_saved() was never called. Without SAVEABLE, the options
are processed immediately instead of being deferred for later.

Also, it's pointless. The purpose of marking command-line options as
SAVEABLE is so that their processing can be correctly ordered with
respect to loading a saved session, so that they can reliably override
settings that the saved session might have defined another way. (E.g.
"plink -A sessionname": processing those options in strict
left-to-right order, the saved session's opinion about agent
forwarding would be used, regardless of the -A option.) So anything
that's not stored in Conf (and hence the saved session) at all doesn't
have any reason to be SAVEABLE.

I think I must have put the SAVEABLE in by thoughtless clone-and-hack.
This commit is contained in:
Simon Tatham 2024-11-21 12:39:04 +00:00
parent 01c404c03d
commit 52b2419028
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmdline.c
View File

@ -926,7 +926,6 @@ int cmdline_process_param(CmdlineArg *arg, CmdlineArg *nextarg,
if (!strcmp(p, "-legacy-stdio-prompts") ||
!strcmp(p, "-legacy_stdio_prompts")) {
RETURN(1);
SAVEABLE(0);
if (!console_set_stdio_prompts(true)) {
cmdline_report_unavailable(p);
return ret;
@ -936,7 +935,6 @@ int cmdline_process_param(CmdlineArg *arg, CmdlineArg *nextarg,
if (!strcmp(p, "-legacy-charset-handling") ||
!strcmp(p, "-legacy_charset_handling")) {
RETURN(1);
SAVEABLE(0);
if (!set_legacy_charset_handling(true)) {
cmdline_report_unavailable(p);
return ret;