nhyatt/putty-source
1
0
Fork 0
mirror of https://git.tartarus.org/simon/putty.git synced 2025-01-10 09:58:01 +00:00
Code Issues Projects Releases Wiki Activity

Remove a redundant ?: in the nethack_keypad code.

Browse Source 
I think all of the cases in this switch must have originally said
(shift_state ? 'this' : 'that'), and in all but the VK_NUMPAD5 case
the two options were different, and I left VK_NUMPAD5 containing a
redundant ?: just to make it line up in a nice table with the others.
But now the others all have more options than that because I had to
support Ctrl as well as Shift modifiers, so there's no reason to have
that silly ?: lingering around (and it annoys Coverity).
This commit is contained in:
Simon Tatham 2017-02-15 05:21:13 +00:00
parent efdbe568e2
commit 54720b2c5a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
windows/window.c
View File

@ -4249,7 +4249,7 @@ static int TranslateKey(UINT message, WPARAM wParam, LPARAM lParam,
*p++ = "hH\010\010"[shift_state & 3]; *p++ = "hH\010\010"[shift_state & 3];
return p - output; return p - output;
case VK_NUMPAD5: case VK_NUMPAD5:
*p++ = shift_state ? '.' : '.'; *p++ = '.';
return p - output; return p - output;
case VK_NUMPAD6: case VK_NUMPAD6:
*p++ = "lL\014\014"[shift_state & 3]; *p++ = "lL\014\014"[shift_state & 3];