From 5a04ae342012c649c4ba6529a0f832aa2534456b Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Thu, 11 Jul 2013 17:24:23 +0000 Subject: [PATCH] Fix a pty-freeing error which caused a segfault if you attempted to use Restart Session in a post-not-close-on-exit pterm. [originally from svn r9909] --- unix/uxpty.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/unix/uxpty.c b/unix/uxpty.c index 99ff6386..5ebd0504 100644 --- a/unix/uxpty.c +++ b/unix/uxpty.c @@ -411,6 +411,7 @@ void pty_pre_init(void) #endif pty = single_pty = snew(struct pty_tag); + pty->conf = NULL; bufchain_init(&pty->output_data); /* set the child signal handler straight away; it needs to be set @@ -725,6 +726,7 @@ static const char *pty_init(void *frontend, void **backend_handle, Conf *conf, if (single_pty) { pty = single_pty; + assert(pty->conf == NULL); } else { pty = snew(struct pty_tag); pty->master_fd = pty->slave_fd = -1; @@ -967,7 +969,17 @@ static void pty_free(void *handle) del234(ptys_by_pid, pty); del234(ptys_by_fd, pty); - sfree(pty); + conf_free(pty->conf); + pty->conf = NULL; + + if (pty == single_pty) { + /* + * Leave this structure around in case we need to Restart + * Session. + */ + } else { + sfree(pty); + } } static void pty_try_write(Pty pty)